Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dvr pixel selector #1089

Merged
merged 38 commits into from
May 14, 2023
Merged

Dvr pixel selector #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6575a2b
First version of the script to selecte pixels for the data volume red…
moralejo Mar 13, 2023
e07fd94
Solved Path issue
moralejo Mar 13, 2023
0d602a5
default output-dir
moralejo Mar 13, 2023
54f542c
Fixed issue with Path
moralejo Mar 13, 2023
2d18f02
Rounding
moralejo Mar 13, 2023
54eeab7
Improve text message
moralejo Mar 14, 2023
0b50412
Improve naming of variables
moralejo Mar 14, 2023
12dfa78
Do not use blosc filter for compression
moralejo Mar 15, 2023
c8a0fd0
Clean-up. Use of EventType. Reduce also event with Unknown event type
moralejo Mar 16, 2023
1fc54a4
Removed obsolete line
moralejo Mar 16, 2023
b5c4b29
Pad run number to 5 digits, with 0's
moralejo Mar 22, 2023
c8f609d
Use only cosmics, and 1 ring of neighbors, in assessing the pixel
moralejo Mar 22, 2023
ac8982b
Improve log message
moralejo Mar 23, 2023
9963661
Speed-up pixel selection
moralejo Mar 23, 2023
138616e
Simplification & improved log message
moralejo Mar 23, 2023
554a06e
Simplified pixel selection function (special cases now treated outside)
moralejo Mar 23, 2023
7885c9e
Put list in correct place
moralejo Mar 23, 2023
391bf5b
Improve log message
moralejo Mar 23, 2023
dcb8e06
Corrected log message
moralejo Mar 23, 2023
be00458
Various changes. Went back to using cosmics to evaluate overall NSB l…
moralejo Mar 23, 2023
d9626e9
Avoid event jump = 0 in sampling of array
moralejo Mar 23, 2023
c42a23e
Several changes to allow processing >1 file, and new option to find
moralejo Mar 24, 2023
1c24b1e
Fixed bug, min_charge_for_certain_selection was not initialized for each
moralejo Mar 26, 2023
9569d10
Print message upon successful completion of execution
moralejo Mar 30, 2023
d12aa39
Changes to use the same DVR settings for all subruns of a run
moralejo Apr 20, 2023
be34b30
Allow processing multiple files also with option --write-pixel-masks
moralejo Apr 21, 2023
fbff73e
Improved description
moralejo Apr 21, 2023
85df1ed
Fixed wrong exit
moralejo Apr 21, 2023
0d5d0ab
Fix log message
moralejo Apr 22, 2023
17b9aeb
Introduced system to re-try the writing of the output in case it fails
moralejo Apr 27, 2023
d199ae6
Changed time for file writing re-tries
moralejo Apr 27, 2023
ee08090
Increased number of writin attempts
moralejo Apr 28, 2023
ce63080
Addressed some comments from review: more clear way of setting the tw…
moralejo May 3, 2023
285768e
Added tests
moralejo May 9, 2023
f1c2b53
Improved comments
moralejo May 9, 2023
6fbefa0
Define muon selection parameters at the beginning. Use the paths to t…
moralejo May 9, 2023
fa9c9a3
Remove some unnecessary printouts
moralejo May 9, 2023
94b1a8e
Improved explanations
moralejo May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lstchain/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ def observed_dl1_files(temp_dir_observed_files, run_summary_path):
dl1_output_path1 = temp_dir_observed_files / "dl1_LST-1.Run02008.0000.h5"
muons_file1 = temp_dir_observed_files / "muons_LST-1.Run02008.0000.fits"
datacheck_file1 = temp_dir_observed_files / "datacheck_dl1_LST-1.Run02008.0000.h5"
dvr_file1 = temp_dir_observed_files / "DVR_settings_LST-1.Run02008.h5"
pixmasks_file1 = temp_dir_observed_files / "Pixel_selection_LST-1.Run02008.0000.h5"

# Second set of files
dl1_output_path2 = temp_dir_observed_files / "dl1_LST-1.Run02008.0100.h5"
Expand Down Expand Up @@ -147,6 +149,24 @@ def observed_dl1_files(temp_dir_observed_files, run_summary_path):
dl1_output_path1
)

run_program(
"lstchain_dvr_pixselector",
"--dl1-files",
dl1_output_path1,
"--output-dir",
temp_dir_observed_files
)

run_program(
"lstchain_dvr_pixselector",
"--dl1-files",
dl1_output_path1,
"--output-dir",
temp_dir_observed_files,
"--action",
"create_pixel_masks"
)

run_program(
"lstchain_data_r0_to_dl1",
"-f",
Expand Down Expand Up @@ -180,6 +200,8 @@ def observed_dl1_files(temp_dir_observed_files, run_summary_path):
'dl1_file1': dl1_output_path1,
'muons1': muons_file1,
'datacheck1': datacheck_file1,
'dvr_file1': dvr_file1,
'pixmasks_file1': pixmasks_file1,
'dl1_file2': dl1_output_path2,
'muons2': muons_file2,
'datacheck2': datacheck_file2
Expand Down
Loading