-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update irf_tool_config.json #1229
Conversation
Set as standard "efficiency cuts" to a 70% efficiency, which is the "baseline analysis" in the LST1 performance paper.
Removed superfluous (and confusing) config file for DL3 creation. It must be the same as for IRF creation.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
=======================================
Coverage 72.67% 72.67%
=======================================
Files 132 132
Lines 13655 13655
=======================================
Hits 9924 9924
Misses 3731 3731 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe the remaining example config file could be named irf_dl3_tool_config.json
Set as standard "efficiency cuts" to a 70% efficiency, which is the "baseline analysis" in the LST1 performance paper.