Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update irf_tool_config.json #1229

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Conversation

moralejo
Copy link
Collaborator

Set as standard "efficiency cuts" to a 70% efficiency, which is the "baseline analysis" in the LST1 performance paper.

Set as standard "efficiency cuts" to a 70% efficiency, which is the "baseline analysis" in the LST1 performance paper.
@moralejo
Copy link
Collaborator Author

Removed superfluous (and confusing) config file for DL3 creation. It must be the same as for IRF creation.
Also:

  • Changed default efficiency cuts to 70% efficiency.
  • Raised the maximum allowed gammaness cut from 0.95 to 0.98. For very high energies gammaness distribution can be very peaky at 1, and this could be limiting performance.

@moralejo moralejo requested a review from rlopezcoto February 12, 2024 17:43
@moralejo moralejo marked this pull request as ready for review February 12, 2024 17:44
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24d2e2c) 72.67% compared to head (9e257bf) 72.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1229   +/-   ##
=======================================
  Coverage   72.67%   72.67%           
=======================================
  Files         132      132           
  Lines       13655    13655           
=======================================
  Hits         9924     9924           
  Misses       3731     3731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo moralejo marked this pull request as draft February 12, 2024 18:49
@moralejo moralejo marked this pull request as ready for review February 12, 2024 22:27
morcuended
morcuended previously approved these changes Feb 13, 2024
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe the remaining example config file could be named irf_dl3_tool_config.json

@moralejo moralejo requested a review from morcuended February 13, 2024 09:24
@moralejo moralejo merged commit 7709de8 into main Feb 13, 2024
9 checks passed
@moralejo moralejo deleted the update-standard-cuts-to-produce-IRFs-and-DL3 branch February 13, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants