Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update irf_tool_config.json #1229

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Update irf_tool_config.json #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9a37bd9
Update irf_tool_config.json
moralejo Feb 12, 2024
201e31c
Removed config file specific to DL3 creation
moralejo Feb 12, 2024
50f73b9
Updated docs
moralejo Feb 12, 2024
3667c64
Update lst_analysis_workflow.rst
moralejo Feb 12, 2024
4fa58b4
Update test_tools.py
moralejo Feb 12, 2024
748e727
Rename irf_tool_config.json to irf_dl3_tool_config.json
moralejo Feb 13, 2024
f294617
Update lst_analysis_workflow.rst
moralejo Feb 13, 2024
e23e67a
Update test_tools.py
moralejo Feb 13, 2024
0ce0a5a
Update test_tools.py
moralejo Feb 13, 2024
9e257bf
Update introduction.rst
moralejo Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions docs/examples/dl3_tool_config.json
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions docs/examples/irf_tool_config.json → docs/examples/irf_dl3_tool_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
"DL3Cuts": {
"min_event_p_en_bin": 100,
"global_gh_cut": 0.7,
"gh_efficiency": 0.9,
"gh_efficiency": 0.7,
"min_gh_cut": 0.1,
"max_gh_cut": 0.95,
"max_gh_cut": 0.98,
"global_alpha_cut": 10,
"global_theta_cut": 0.2,
"theta_containment": 0.68,
"alpha_containment": 0.68,
"theta_containment": 0.7,
"alpha_containment": 0.7,
"min_theta_cut": 0.1,
"max_theta_cut": 0.32,
"fill_theta_cut": 0.32,
Expand Down
9 changes: 2 additions & 7 deletions docs/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Here is an example configuration file for the IRF creation step.

.. toggle::

.. include:: examples/irf_tool_config.json
.. include:: examples/irf_dl3_tool_config.json
:code: json


Expand All @@ -126,12 +126,7 @@ To write DL3 files, you should use:

For more information, try ``--help`` or see the :doc:`lstchain_api/index`.

Here is an example configuration file for the IRF creation step.

.. toggle::

.. include:: examples/dl3_tool_config.json
:code: json
You should use the same configuration file used for the IRF creation (hence you have the same cuts).


Post DL3 analysis
Expand Down
7 changes: 3 additions & 4 deletions docs/lst_analysis_workflow.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,9 @@ DL3/IRF config files
--------------------


DL3/IRF example config files are provided in `docs/example`:
An example config file for IRF/DL3 creation is provided in `docs/example`:

- `dl3_tool_config.json <dl3_tool_config.json>`_
- `irf_tool_config.json <irf_tool_config.json>`_
- `irf_dl3_tool_config.json <irf_dl3_tool_config.json>`_


Such files should be used to produce DL3 files and IRFs from DL2 (see :ref:`the Analysis Steps <introduction>`)
Expand Down Expand Up @@ -175,4 +174,4 @@ Then, you can use the conda environment used to produce the MC files:
The `ENV_NAME` used for MC production is provided in the lstmcipe config file.


Note: you may also activate the environment defined here using your own conda installation.
Note: you may also activate the environment defined here using your own conda installation.
4 changes: 2 additions & 2 deletions lstchain/tools/tests/test_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def test_create_irf_full_enclosure_with_config(
from lstchain.tools.lstchain_create_irf_files import IRFFITSWriter

irf_file = temp_dir_observed_files / "fe_irf.fits.gz"
config_file = os.path.join(os.getcwd(), "./docs/examples/irf_tool_config.json")
config_file = os.path.join(os.getcwd(), "./docs/examples/irf_dl3_tool_config.json")

assert (
run_tool(
Expand Down Expand Up @@ -266,7 +266,7 @@ def test_create_dl3_with_config(temp_dir_observed_files, observed_dl2_file):
"""
from lstchain.tools.lstchain_create_dl3_file import DataReductionFITSWriter

config_file = os.path.join(os.getcwd(), "docs/examples/dl3_tool_config.json")
config_file = os.path.join(os.getcwd(), "docs/examples/irf_dl3_tool_config.json")

assert (
run_tool(
Expand Down
Loading