-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StatisticsAggregator API #2554
Conversation
I'm having some troubles with ruff, which makes pylint fail. Can someone please help? Thanks in advance! |
For future reference: the issue was that the pre-commit hook wasn't yet installed for some of the commits. To run it on all files affected by this PR, the solution was:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We can generalize it more later, but for now this is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monitoring/extractor.py
is a new module, it needs to be added to the API docs.
Please add it in docs/api-reference/monitoring/
.
You can check the other files there
I tried to added following the structure of the other modules, but the docs are failing. Can you please have a look @maxnoe? Thanks in advance! |
The error is not in the new docs page (these are fine!) but in the docstring of one of the new classes:
which are now included in the docs, which is why you didn't see them before. You need double back-ticks in rst for code:
|
This PR adds a skeleton API for the statistical calculation of pixel-wise values over a given time interval. The current implementation features two different extraction methods, i.e. a
PlainExtractor
based on numpy functions andSigmaClippingExtractor
based on astropy functions, which are also used inlstchain
.I'm marking this PR as a draft because of the following discussion points:
sample_size
?Related to #2542.