OutlierDetector components #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TjarkMiener
requested review from
maxnoe,
mexanick,
kosack,
FrancaCassol,
Hckjs and
ctoennis
This comment has been minimized.
This comment has been minimized.
8 tasks
mexanick
reviewed
Jul 27, 2024
This comment has been minimized.
This comment has been minimized.
mexanick
previously approved these changes
Jul 27, 2024
kosack
reviewed
Jul 31, 2024
|
This PR needs to be rebased and "outlier files" have to moved to the |
TjarkMiener
force-pushed
the
outlier_detector
branch
from
cc91abf
to
d3fda92
Compare
This comment has been minimized.
This comment has been minimized.
…cription removed 'Based' in the class names
This comment has been minimized.
This comment has been minimized.
kosack
requested changes
Aug 5, 2024
This comment has been minimized.
This comment has been minimized.
mexanick
previously approved these changes
Aug 5, 2024
mexanick
previously approved these changes
Aug 5, 2024
This comment has been minimized.
This comment has been minimized.
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
kosack
approved these changes
Aug 6, 2024
mexanick
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added outlier detection approaches. The sub classes can be applied to any astropy column of shape (n_entries, n_channels, n_pix) returning an outlier mask of the same shape. The code utilizing this components later need to handle multiple instances and therefore combine the returning outlier masks.
–––
Related: #2542