Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container/component/tool for pedestal estimation #115

Merged
merged 21 commits into from
Mar 29, 2024

Merge branch 'main' into pedestal_maker_0

1f09a0d
Select commit
Loading
Failed to load commit list.
Merged

Add container/component/tool for pedestal estimation #115

Merge branch 'main' into pedestal_maker_0
1f09a0d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 22, 2024 in 1s

39.43% (+10.88%) compared to 51b976c

View this Pull Request on Codecov

39.43% (+10.88%) compared to 51b976c

Details

Codecov Report

Attention: Patch coverage is 92.07650% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 39.43%. Comparing base (51b976c) to head (1f09a0d).

Files Patch % Lines
src/nectarchain/makers/core.py 26.66% 11 Missing ⚠️
...c/nectarchain/makers/calibration/pedestalMakers.py 85.93% 9 Missing ⚠️
.../nectarchain/makers/component/PedestalComponent.py 93.38% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #115       +/-   ##
===========================================
+ Coverage   28.54%   39.43%   +10.88%     
===========================================
  Files          62       65        +3     
  Lines        4102     4453      +351     
===========================================
+ Hits         1171     1756      +585     
+ Misses       2931     2697      -234

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov