Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to AnnotateRoutes::HeaderGenerator and refactor methods #792

Merged
merged 7 commits into from
Apr 5, 2020
Merged

Add methods to AnnotateRoutes::HeaderGenerator and refactor methods #792

merged 7 commits into from
Apr 5, 2020

Conversation

nard-tech
Copy link
Collaborator

cf. #790

In order to refactor AnnoateRoutes, I added methods to AnnotateRoutes::HeaderGenerator and refactor methods.

I will add AnnotateRoutes::AnnotationProcessor and AnnotateRoutes::RemovalProcessor in next PR.

drwl
drwl approved these changes Apr 5, 2020
View reviewed changes
Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drwl drwl merged commit ce7f22d into ctran:develop Apr 5, 2020
@nard-tech nard-tech deleted the feature/refactor_annotate_routes/header_generator_v2 branch April 6, 2020 01:11
@nard-tech nard-tech mentioned this pull request Apr 6, 2020
Closed
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
@nard-tech @vfonic
Add methods to AnnotateRoutes::HeaderGenerator and refactor methods (c…
5df4b1a 
…tran#792)

cf. ctran#790 

In order to refactor `AnnoateRoutes`, I added methods to `AnnotateRoutes::HeaderGenerator` and refactor methods.

I will add `AnnotateRoutes::AnnotationProcessor` and `AnnotateRoutes::RemovalProcessor` in next PR.
ocarta-l pushed a commit to ocarta-l/annotate_models that referenced this pull request Jun 18, 2021
@nard-tech @ocarta-l
Add methods to AnnotateRoutes::HeaderGenerator and refactor methods (c…
ba9812b 
…tran#792)

cf. ctran#790 

In order to refactor `AnnoateRoutes`, I added methods to `AnnotateRoutes::HeaderGenerator` and refactor methods.

I will add `AnnotateRoutes::AnnotationProcessor` and `AnnotateRoutes::RemovalProcessor` in next PR.
This was referenced Feb 9, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwl drwl drwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nard-tech @drwl