Add AnnotateRoutes::AnnotationProcessor and AnnotateRoutes::RemovalProcessor #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nard-tech, Is this still valid? If so, can you fix the conflict? |
|
Hello @ctran, the conflict is in Now this PR is valid. Please merge if there is no problem. |
nard-tech
force-pushed
the
feature/refactor_annotate_routes/processors
branch
from
2cf8313
to
4697388
Compare
This was referenced Mar 31, 2021
Closed
drwl
added a commit
to drwl/annotaterb
that referenced
this pull request
Feb 16, 2023
nard-tech
force-pushed
the
feature/refactor_annotate_routes/processors
branch
from
cc5fb44
to
5d01c41
Compare
This was referenced Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #790, #792
In order to refactor AnnoateRoutes, I added
AnnotateRoutes::AnnotationProcessorandAnnotateRoutes::RemovalProcessor.Refactoring AnnotateRoutes is finished in this PR and I would like to refactor AnnotateModels in a like way.