-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen activerecord restriction to work with rails 7 #912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ctran can we have this merged in? I've been using this with rc versions till yesterday and everything looks good |
@ctran requesting a quick merge for this. |
When do you think this could be merged? :) |
1 similar comment
@ctran any chance we can merge this in? |
Looking forward for merge ) |
Hm, any reason the "ci" build is failing? |
I thought it was the extra rake task, but now that I've reverted we get the same result. Not happening on my computer with different versions either. Still trying to replicate. |
Appreciate the help. I'm trying to do a release with this change included. |
No prob, whatever works! |
I confirmed the dependency change caused the ci failure. I'm not sure why they failed though. |
This requires updates to the Gemfile and also causes the integration tests to fail. |
@ctran I think I figured it out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This change allows the gem to work with Rails 7 now that it's out.
I've been using it for a while with alpha and RC versions and at least models and routes work fine.
EDIT:
Just included as a bonus arake routes
task that fixes the problems that showed up when rails renamed the task torails routes