Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen activerecord restriction to work with rails 7 #912

Merged
merged 6 commits into from
Feb 3, 2022

Conversation

dabit
Copy link
Contributor

@dabit dabit commented Dec 16, 2021

This change allows the gem to work with Rails 7 now that it's out.

I've been using it for a while with alpha and RC versions and at least models and routes work fine.

EDIT:

Just included as a bonus a rake routes task that fixes the problems that showed up when rails renamed the task to rails routes

Copy link

@davidteren davidteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfie-max
Copy link

@ctran can we have this merged in? I've been using this with rc versions till yesterday and everything looks good

@ryanb ryanb mentioned this pull request Dec 17, 2021
@thenamankumar
Copy link

@ctran requesting a quick merge for this.

@Flink
Copy link

Flink commented Jan 13, 2022

When do you think this could be merged? :)

@StoneGod
Copy link

@ctran

1 similar comment
@ayoa77
Copy link

ayoa77 commented Jan 18, 2022

@ctran

@robbevp robbevp mentioned this pull request Jan 18, 2022
annotate.gemspec Outdated Show resolved Hide resolved
@mileszim
Copy link

@ctran any chance we can merge this in?

@slayer
Copy link

slayer commented Jan 27, 2022

Looking forward for merge )

@ctran ctran added this to the v3.2.0 milestone Feb 1, 2022
@ctran ctran mentioned this pull request Feb 1, 2022
@ctran
Copy link
Owner

ctran commented Feb 1, 2022

Hm, any reason the "ci" build is failing?

@dabit
Copy link
Contributor Author

dabit commented Feb 2, 2022

I thought it was the extra rake task, but now that I've reverted we get the same result. Not happening on my computer with different versions either. Still trying to replicate.

@ctran
Copy link
Owner

ctran commented Feb 2, 2022

Appreciate the help. I'm trying to do a release with this change included.

@dabit
Copy link
Contributor Author

dabit commented Feb 2, 2022

No prob, whatever works!

@ctran
Copy link
Owner

ctran commented Feb 2, 2022

I confirmed the dependency change caused the ci failure. I'm not sure why they failed though.

@ctran
Copy link
Owner

ctran commented Feb 3, 2022

This requires updates to the Gemfile and also causes the integration tests to fail.

@dabit
Copy link
Contributor Author

dabit commented Feb 3, 2022

@ctran I think I figured it out

Copy link
Owner

@ctran ctran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctran ctran changed the title Loosen activerecord restriction in order to be used with rails 7 Loosen activerecord restriction to work with rails 7 Feb 3, 2022
@ctran ctran merged commit eaacc0b into ctran:develop Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.