Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rails 7 #915

Closed
wants to merge 1 commit into from
Closed

Support rails 7 #915

wants to merge 1 commit into from

Conversation

sebyx07
Copy link

@sebyx07 sebyx07 commented Dec 18, 2021

No description provided.

ziraqyoung added a commit to ziraqyoung/form4tracker that referenced this pull request Dec 22, 2021
@ziraqyoung
Upgrade to Rails 7
5e257bd 
- `annotate` gem doesnot support Active Record 7, there is a PR for it
  but not yet merged ctran/annotate_models#915
- Remove `rexml` gem, turn out rails 7 has fixed this for Ruby 3
artplan1
artplan1 suggested changes Dec 23, 2021
View reviewed changes
Copy link

@artplan1 artplan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate of #912

@ctran ctran mentioned this pull request Feb 1, 2022
Merged
@ctran
Copy link
Owner

ctran commented Feb 1, 2022

Thanks. I'll merge #912 instead

@ctran ctran added this to the v3.2.0 milestone Feb 1, 2022
@ctran ctran closed this Feb 2, 2022
@ctran ctran reopened this Feb 2, 2022
@ctran ctran closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artplan1 artplan1 artplan1 requested changes

@developerby developerby developerby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sebyx07 @ctran @developerby @artplan1