next -> redux opinionated #366

sergiokopplin · 2017-02-21T21:05:57Z

Might need some help here.

update broken feature/flow link in docs

* Updated CSP for nonce backwards compatibility * Documented * Updates comments

- `SERVER_PORT` to `PORT` - `SERVER_HOST` to `HOST` - `CLIENT_DEVSERVER_PORT` to `CLIENT_DEV_PORT` - Replaces `code-split-component` with `react-async-component` - Renames the `nodeBundlesIncludeNodeModuleFileTypes` config property to `nodeExternalsFileTypeWhitelist` - Refactors the server and serviceworker offline page generation. We now use a set of React components (`ServerHTML` and `HTML`) to manage our HTML in a uniform fashion. - Refactors how we resolve environment specific configuration values. `NODE_ENV` is reserved for specifying a `development` or `production` build now. Use `CONF_ENV` to specify a target environment if you would like to resolve an environment specific .env file. - Refactors the client configuration filter rule to be contained within the main configuration and moves the configuration object creation into the server middleware. - Renames the `safeGetConfig` to `config`, and made it a default export. - Removes the `cross-env` library. - All server/client/shared code all use the shared config helper. - Updated dependencies, including to the latest Webpack official 2 release. - New babel plugins to optimise React production build performance. - Adds new icon sets. - Chrome favicon request issue. - Cleans up the package scripts. - Service worker would fail if a subfolder was added to the public folder.

…sary. Everything internal (tooling/docs) has been moved to an "internal" folder. The rest lives at root. The configuration has been given a massive once over too. I really disliked how there were multiple ways the config values were being read throughout the project. Everything has been changed now to use a config helper that lives in the '<projectroot>/config/' folder. All things config lives in that folder now too.

Removes CONF_ENV and refactors environment variable resolution to use NODE_ENV again.

…ers (#357)

strues · 2017-05-03T21:12:46Z

It's certainly close to ready, if not completely ready. Havent noticed any other issues myself.

brianfeister · 2017-05-05T17:20:48Z

I think I uncovered a minor bug where wrapping components differently than you're doing in the boilerplate causes the async /post/:id route to choke, I think this might be a better approach

https://github.com/sergiokopplin/react-universally/pull/3

Fix Router v2 Implementation

sergiokopplin · 2017-05-05T18:58:58Z

Nice catch @brianfeister !!!

Passing colors from server to console in develop.

…nionated

sergiokopplin · 2017-05-25T21:37:07Z

Hey guys!
The branch has 1 problem which affects the render speed.

I was looking as seems to be a problem with the async wrapper.
Can someone helps me with that? Not finding the problem.
Have you fixed that in another branch @ctrlplusb?
Do you have this problem in your project @birkir?

related:
#43

sergiokopplin · 2017-05-25T23:21:28Z

Fixed!

I changed this line from client/index:

const rehydrateState = window.__JOBS_REHYDRATE_STATE__;

to:

const rehydrateState = window.__JOBS_STATE__;

maryokhin · 2017-05-31T11:23:18Z

client/index.js

@@ -30,7 +30,7 @@ const supportsHistory = 'pushState' in window.history;

 // Get any rehydrateState for the async components.
 // eslint-disable-next-line no-underscore-dangle
-const asyncComponentsRehydrateState = window.__ASYNC_COMPONENTS_REHYDRATE_STATE__;
+const asyncComponentsRehydrateState = window.__JOBS_STATE__;


Should this part in server/middleware/reactApplication/ServerHTML.js also reflect this?

ifElse(asyncComponentsState)(() => inlineScript( `window.__ASYNC_COMPONENTS_REHYDRATE_STATE__=${serialize(asyncComponentsState)};`, ), ),

also reflect this change?

maryokhin · 2017-05-31T11:49:19Z

Running this branch as-is gives me a bunch of errors in the console, is that normal?

Everything renders fine though.

sergiokopplin · 2017-05-31T14:10:44Z

@maryokhin can you take a look now?

maryokhin · 2017-05-31T14:46:55Z

@sergiokopplin yep, console is clean now.

oyeanuj · 2017-06-21T18:26:57Z

@sergiokopplin @ctrlplusb Ready to merge? 🎉

strues · 2017-06-21T23:15:27Z

LGTM

ctrlplusb · 2017-06-21T23:54:21Z

If @strues is happy lets go! 👍

ctrlplusb · 2017-06-21T23:56:20Z

Well done to @sergiokopplin for all his hard work on this one, and a huge thanks to everyone else who helped along the way. 👍

sergiokopplin · 2017-06-22T22:16:41Z

Awesome!!!! :)

sergiokopplin · 2017-06-22T22:20:05Z

@ctrlplusb can i add my name on the contributors? :)

ctrlplusb · 2017-06-22T22:34:11Z

Of course yes!

Sorry I have been completely dropping the ball on managing this project at the moment. I have so many other gears turning, with some exciting new developments. I appreciate to the moon your contribution. In fact, expect an invite. 👍

sergiokopplin · 2017-06-22T22:36:18Z

Thanks @ctrlplusb!

* feature/redux-opinionated: (25 commits) Adding logging for redux actions, and updating DevTools syntax to the latest. Updating tests to pass. Pushing updated lock files (without merge indicators) Added lock files. Also, previous commit was merging master into redux/opinionated. Ignore previous commit message Server logging enhancements (ctrlplusb#508) Minor readme updates (ctrlplusb#501) Remove link to phantom page Updates failing snapshots. Updates deps and adds an npmrc to make sure dep installs are always exact. Replaces yarn with npm. Added 100% coverage for utils folder (ctrlplusb#484) Fix link to phantom page in the documentation. (ctrlplusb#507) Rebase Remove link to phantom page Checkout refinements and deps updates from ctrlplusb#489 Update redux dependencies next -> redux opinionated (ctrlplusb#366) Updates to latest react-jobs and fixes job attached to Post. Migrates from the 'task routes' implementation for data loading to the usage of the 'react-jobs' library. Fixes missing dependencies. ...

sergiokopplin · 2017-10-16T11:30:33Z

@ctrlplusb hey man! i've pushed a commit that was supposed to be a pr on the next branch to add me as contributor. sorry for that, my mistake! Can you add me on readme also? thanks

ctrlplusb · 2017-10-16T13:43:49Z

No worries, my sincere apologies for not having you in there already!

ctrlplusb and others added 30 commits January 13, 2017 07:18

Adds modernizr with illustrative example. closes #256

e2d449f

Linting now occurs on config, src and tools. closes #314

c379c86

Updates dependencies.

5665b31

update broken feature/flow link in docs

c22814f

Merge pull request #324 from markshlick/patch-1

28769d1

update broken feature/flow link in docs

Merge branch 'master' into next

97b0468

Updates dependencies.

4602df1

Updated CSP to add backwards compatibility to nonce. (#344)

2438517

* Updated CSP for nonce backwards compatibility * Documented * Updates comments

Merge branch 'master' into next

fd693c8

fix sw to exclude directory (#305)

0b47de6

Merge branch 'master' into next

8f319b3

Adds Dion Dirza as a contributor 🎉

ae7249c

Fixes analyze.

2de7d2e

Docs and cleaning up.

6721603

Updates docs and version.

d79d624

Removes code-split-component.

8452f77

Updates deps and fixes config refs.

eebd879

Fixes offline page.

4593e9d

Cleans up and centralises util functions.

d0ba64e

Minor fixes.

66260b7

Renames config/get to config/getConfig

ba2af33

Removes CONF_ENV and refactors environment variable resolution to use NODE_ENV again.

fixes typo: laoder -> loader (#353)

2180d3f

fixes typo: server -> serve (#354)

22e6958

Huuuuuuuge update. Getting closer to v13.

db371ec

Fixes incorrect import path in Menu.test.js (#360)

e3b99f6

Updates Error 404 component so that we can set 404 status on SSR rend…

e8f027e

…ers (#357)

Updates dependencies.

f8e7fe5

Updates contributors and comments.

dfd9426

Fix Router v2 Implementation

422f05a

Merge pull request #3 from brianfeister/patch-1

4bbcec6

Fix Router v2 Implementation

birkir and others added 2 commits May 7, 2017 17:09

Add color support for stdout (#443)

bcdce08

Passing colors from server to console in develop.

Merge remote-tracking branch 'upstream/master' into feature/redux-opi…

20ede0e

…nionated

master -> redux: fixing store problem

7d808de

maryokhin reviewed May 31, 2017

View reviewed changes

fixing stores

cfa8da0

birkir mentioned this pull request Jun 21, 2017

Feature/redux opinionated #458

Closed

ctrlplusb merged commit 9ee484c into ctrlplusb:feature/redux-opinionated Jun 21, 2017

sergiokopplin mentioned this pull request Jul 13, 2017

Merge master into feature/redux-opinionated #471

Merged

sergiokopplin deleted the feature/redux-opinionated branch August 17, 2017 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

next -> redux opinionated #366

next -> redux opinionated #366

sergiokopplin commented Feb 21, 2017 •

edited

Loading

strues commented May 3, 2017

brianfeister commented May 5, 2017

sergiokopplin commented May 5, 2017

sergiokopplin commented May 25, 2017 •

edited

Loading

sergiokopplin commented May 25, 2017

maryokhin May 31, 2017 •

edited

Loading

maryokhin commented May 31, 2017 •

edited

Loading

sergiokopplin commented May 31, 2017

maryokhin commented May 31, 2017

oyeanuj commented Jun 21, 2017

strues commented Jun 21, 2017

ctrlplusb commented Jun 21, 2017

ctrlplusb commented Jun 21, 2017

sergiokopplin commented Jun 22, 2017

sergiokopplin commented Jun 22, 2017 •

edited

Loading

ctrlplusb commented Jun 22, 2017

sergiokopplin commented Jun 22, 2017

sergiokopplin commented Oct 16, 2017

ctrlplusb commented Oct 16, 2017

next -> redux opinionated #366

next -> redux opinionated #366

Conversation

sergiokopplin commented Feb 21, 2017 • edited Loading

strues commented May 3, 2017

brianfeister commented May 5, 2017

sergiokopplin commented May 5, 2017

sergiokopplin commented May 25, 2017 • edited Loading

sergiokopplin commented May 25, 2017

maryokhin May 31, 2017 • edited Loading

Choose a reason for hiding this comment

maryokhin commented May 31, 2017 • edited Loading

sergiokopplin commented May 31, 2017

maryokhin commented May 31, 2017

oyeanuj commented Jun 21, 2017

strues commented Jun 21, 2017

ctrlplusb commented Jun 21, 2017

ctrlplusb commented Jun 21, 2017

sergiokopplin commented Jun 22, 2017

sergiokopplin commented Jun 22, 2017 • edited Loading

ctrlplusb commented Jun 22, 2017

sergiokopplin commented Jun 22, 2017

sergiokopplin commented Oct 16, 2017

ctrlplusb commented Oct 16, 2017

sergiokopplin commented Feb 21, 2017 •

edited

Loading

sergiokopplin commented May 25, 2017 •

edited

Loading

maryokhin May 31, 2017 •

edited

Loading

maryokhin commented May 31, 2017 •

edited

Loading

sergiokopplin commented Jun 22, 2017 •

edited

Loading