Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Server logging enhancements #508

Merged
merged 6 commits into from
Oct 3, 2017

Conversation

oyeanuj
Copy link
Contributor

@oyeanuj oyeanuj commented Oct 1, 2017

Hi folks! Just a small PR that ports over some changes I made in my fork -

  1. Fusses over the logging aesthetic, adds some details.
  2. Improves the 'server running' message.
  3. Consolidates log calls to the log function declared as a util function.
  4. Creates another level of logging called special to help visually prioritize the different message.
  5. Adds pretty-error for more readable node error stacks.

Let me know if this looks good!

@sergiokopplin
Copy link
Collaborator

@oyeanuj nice work!

@strues
Copy link
Collaborator

strues commented Oct 3, 2017

Merged!

@strues strues merged commit 111a170 into ctrlplusb:master Oct 3, 2017
@oyeanuj oyeanuj deleted the improved-server-logging branch October 3, 2017 17:58
oyeanuj added a commit to oyeanuj/react-universally that referenced this pull request Oct 3, 2017
* ctrlplusb/master:
  Server logging enhancements (ctrlplusb#508)
  Minor readme updates (ctrlplusb#501)
oyeanuj added a commit to oyeanuj/react-universally that referenced this pull request Oct 6, 2017
* Improving logging experience + consolidating to single log function

* Adding pretty-error for more readable node error stack

* Fix eslint error

* Logging requests received

* Re-commit logging requests received
oyeanuj added a commit to oyeanuj/react-universally that referenced this pull request Oct 6, 2017
* colors-to-chalk:
  Replacing colors with chalk
  Server logging enhancements (ctrlplusb#508)
  Minor readme updates (ctrlplusb#501)
oyeanuj pushed a commit to oyeanuj/react-universally that referenced this pull request Oct 6, 2017
* feature/redux-opinionated: (25 commits)
  Adding logging for redux actions, and updating DevTools syntax to the latest.
  Updating tests to pass.
  Pushing updated lock files (without merge indicators)
  Added lock files. Also, previous commit was merging master into redux/opinionated. Ignore previous commit message
  Server logging enhancements (ctrlplusb#508)
  Minor readme updates (ctrlplusb#501)
  Remove link to phantom page
  Updates failing snapshots.
  Updates deps and adds an npmrc to make sure dep installs are always exact.
  Replaces yarn with npm.
  Added 100% coverage for utils folder (ctrlplusb#484)
  Fix link to phantom page in the documentation. (ctrlplusb#507)
  Rebase
  Remove link to phantom page
  Checkout refinements and deps updates from ctrlplusb#489
  Update redux dependencies
  next -> redux opinionated (ctrlplusb#366)
  Updates to latest react-jobs and fixes job attached to Post.
  Migrates from the 'task routes' implementation for data loading to the usage of the 'react-jobs' library.
  Fixes missing dependencies.
  ...
strues pushed a commit that referenced this pull request Oct 11, 2017
* Minor readme updates (#501)

* Update Webpack version

* Update Webpack version

* Fix acronym

* Fix markdown formatting.

* Update that redux branch does not have Flow

* Add 'Who is using it' section in the README

As per @ctrlplusb’s comment here:
#437 (comment)
98854669

* Server logging enhancements (#508)

* Improving logging experience + consolidating to single log function

* Adding pretty-error for more readable node error stack

* Fix eslint error

* Logging requests received

* Re-commit logging requests received

* Replacing colors with chalk
xzyfer pushed a commit to xzyfer/react-universally that referenced this pull request Oct 16, 2017
* Improving logging experience + consolidating to single log function

* Adding pretty-error for more readable node error stack

* Fix eslint error

* Logging requests received

* Re-commit logging requests received
ctrlplusb pushed a commit that referenced this pull request Oct 16, 2017
* Minor readme updates (#501)

* Update Webpack version

* Update Webpack version

* Fix acronym

* Fix markdown formatting.

* Update that redux branch does not have Flow

* Add 'Who is using it' section in the README

As per @ctrlplusb’s comment here:
#437 (comment)
98854669

* Server logging enhancements (#508)

* Improving logging experience + consolidating to single log function

* Adding pretty-error for more readable node error stack

* Fix eslint error

* Logging requests received

* Re-commit logging requests received

* Replacing colors with chalk
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants