This repository has been archived by the owner on Jun 3, 2019. It is now read-only.
Colors to chalk #512
Merged
Colors to chalk #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with main repo
* Update Webpack version * Update Webpack version * Fix acronym * Fix markdown formatting. * Update that redux branch does not have Flow * Add 'Who is using it' section in the README As per @ctrlplusb’s comment here: ctrlplusb#437 (comment) 98854669
* Improving logging experience + consolidating to single log function * Adding pretty-error for more readable node error stack * Fix eslint error * Logging requests received * Re-commit logging requests received
* ctrlplusb/master: Server logging enhancements (ctrlplusb#508) Minor readme updates (ctrlplusb#501)
|
Awesome, thanks for taking this on @oyeanuj Would you mind pointing it to the I wanna keep |
|
@ctrlplusb Done! Let me know if it looks good! |
|
👍 |
ctrlplusb
pushed a commit
that referenced
this pull request
Oct 16, 2017
* Minor readme updates (#501) * Update Webpack version * Update Webpack version * Fix acronym * Fix markdown formatting. * Update that redux branch does not have Flow * Add 'Who is using it' section in the README As per @ctrlplusb’s comment here: #437 (comment) 98854669 * Server logging enhancements (#508) * Improving logging experience + consolidating to single log function * Adding pretty-error for more readable node error stack * Fix eslint error * Logging requests received * Re-commit logging requests received * Replacing colors with chalk
oyeanuj
added a commit
to oyeanuj/react-universally
that referenced
this pull request
Oct 19, 2017
* commit 'db747d5': (24 commits) Merging origin/next renderToNodeStream for server rendering. remove yarn.lock and add to gitignore. (ctrlplusb#526) Fixes snapshot test. Minor cleanup. Makes minor adjustment to eslint rules. Removes the preinstall script. Removes react-hot-loader wrapper component. Closes ctrlplusb#486 Updates readme. Refactors logging from server so that it doesn't reference internals, it rather uses a util from the shared code. This has resulted in chalk becoming a dependency. Moves docs to root and removes references to feature branches. Updates deps. adding contributors Updates contributors. Muchos love to all ❤️ Adds prettier configuration to package.json Adds prettier config to eslint so that all style rules are ignored, and moves all eslint config into package.json. Fix raf polyfill and move all `universal` polyfills in sared dir (ctrlplusb#516) Colors to chalk (ctrlplusb#512) Removes prettier-eslint. Changes nvmrc to node 8. Updates dependencies. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks! I know this has been discussed a couple of times before with the decision to ultimately not make the change. But I ran into some webpack errors with
colorsand decided to change it in my fork.Essentially,
colorshasn't seen updates for a couple of years, and has an outstanding issue preventing it from always playing well withwebpack. As per the rule mentioned by @strues, time to update.So, figured I'd offer the PR incase there was interest.