Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up JRuby build #657

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Fix up JRuby build #657

merged 3 commits into from
Jul 12, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jul 6, 2019

Summary

The build was broken in #656. This PR fixes that.

Details

  • Changes the annotation for the debug feature to not run it on JRuby. Running a debugger in the DebugProcess runner doesn't actually allow interacting with in on JRuby.
  • Changes the annotation for some other scenarios that actually run fine on JRuby.
  • Cleans up a useless assignment to @interactive.

Motivation and Context

The build is currently broken in master.

How Has This Been Tested?

The relevant scenarios were run on JRuby and MRI.

Types of changes

  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

mvz added 3 commits July 5, 2019 19:03
@mvz
Remove unused @Interactive ivar from step
dab342d
@mvz
Stop skipping scenarios that work fine on JRuby
0c2de91
@mvz
Skip debug feature on JRuby
d3d606a 
This feature does not actually work fully on JRuby. The debugger will
start, but after that, interaction with it is impossible.
@mvz mvz changed the title Fix up JRuby Fix up JRuby build Jul 6, 2019
olleolleolle
olleolleolle approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great steps forward. The commits each tell a story. Thanks for the cohesive communication here!

@mvz mvz merged commit 0d7838f into master Jul 12, 2019
@mvz mvz deleted the fix-up-jruby branch July 12, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle