Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up JRuby build #657

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Fix up JRuby build #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dab342d
Remove unused @interactive ivar from step
mvz Jul 5, 2019
0c2de91
Stop skipping scenarios that work fine on JRuby
mvz Jul 5, 2019
d3d606a
Skip debug feature on JRuby
mvz Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/03_testing_frameworks/cucumber/steps/command/debug_your_command_in_aruba.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: Debug your command in cucumber-test-run
Given I use a fixture named "cli-app"
And the default aruba exit timeout is 60 seconds

@requires-readline
@unsupported-on-platform-java
Scenario: You can use a debug repl in your cli program

If you want to debug an error, which only occurs in one of your
Expand Down
3 changes: 0 additions & 3 deletions features/06_use_aruba_cli/open_console.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Feature: Aruba Console
aruba:001:0>
"""

@unsupported-on-platform-java
Scenario: Show help
Given I run `aruba console` interactively
And I type "aruba_help"
Expand All @@ -29,7 +28,6 @@ Feature: Aruba Console
Documentation:
"""

@unsupported-on-platform-java
Scenario: Show methods
Given I run `aruba console` interactively
And I type "aruba_methods"
Expand All @@ -43,7 +41,6 @@ Feature: Aruba Console
* setup_aruba
"""

@unsupported-on-platform-java
Scenario: Has history
Given I run `aruba console` interactively
And I type "aruba_methods"
Expand Down
3 changes: 1 addition & 2 deletions lib/aruba/cucumber/command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
end

When(/^I run `([^`]*)` interactively$/) do |cmd|
cmd = sanitize_text(cmd)
@interactive = run_command(cmd)
run_command(sanitize_text(cmd))
end

# Merge interactive and background after refactoring with event queue
Expand Down