Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new messages fields #131

Merged
merged 10 commits into from
Nov 8, 2024
Merged

Add support for new messages fields #131

merged 10 commits into from
Nov 8, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Oct 26, 2024

🤔 What's changed?

This PR brings in messages v27, which comes with various new messages and fields from cucumber/messages#102. We're addressing some but not all of those new fields, specifically:

  • TestRunStarted.id added
  • TestCase.testRunStartedId added
  • TestRunFinished.testRunStartedId added
  • Hook.type added

The other changes which are for global hooks will be picked up in the next PR.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review October 31, 2024 15:49
@mpkorstanje mpkorstanje self-requested a review November 6, 2024 17:26
# Conflicts:
#	package-lock.json
#	package.json
@davidjgoss davidjgoss merged commit 1b7fe26 into main Nov 8, 2024
3 checks passed
@davidjgoss davidjgoss deleted the feat/messages-27 branch November 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants