chore: use .node-version to fixed node version #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baboon-king
commented
Mar 24, 2024
.node-version
Outdated
| @@ -0,0 +1 @@ | |||
| 20 | |||
There was a problem hiding this comment.
为什么只是大版本 20，不是更具体的版本？
- 20 的所有版本都支持，这样贡献者们不必为了 一个小版本不同，再次安装一个新的 Node 在机器上。?
- 次版本，和小版本变更只有极小的机率产生 破坏性变更。
所以我更推荐锁定 大版本即可
baboon-king
force-pushed
the
373
branch
2 times, most recently
from
a456940
to
f3b67f2
Compare
所以这个 pr 可以只添加一个 .node-version 即可 ， 注意版本要和 engines 对齐 |
好的，明白了。我将很快补充新的提交 |
cuixiaorui
added a commit
that referenced
this pull request
Apr 3, 2024
* feat: home upgrade v0.1 (unfinished) * feat: add PayCard.vue * feat: opt home page header style, separate component * feat: separate components * feat: opt home style * fix: index.vue commit import and fix Navbar.vue h1 style * fix: Navbar.vue button * feat: PayCard style feat and fix some question * feat: feat some style * feat: feat PayCard style * feat: feat Questions style * fix: delete more svg * feat: add next button (#413) * feat: addNextButton * feat: addChangeSkipSetting * refactor: skip --------- Co-authored-by: cuixiaorui <cui_xiaorui@126.com> * fix: Initialize the default shortcut key * test: fix test case * fix: rank Loading show position * feat: jump to specific statement (#404) * feat: to specific statement * refactor: contents use virtual scroll * feat: click contents outside then hide * feat: save learned progress * feat: content text line break * refactor: change virtual scroll * fix: unit test fetch history error * feat: contents toogle mode * refactor: contents on click outside * refactor: detect whether the function is learned --------- Co-authored-by: cuixiaorui <cui_xiaorui@126.com> * chore: use .node-version to fixed node version (#374) * feat: Answer page support Space next sentence * feat: add to back previous statement (#425) * feat: addPreviousButton * fix: VariableValue * refactor: delete message * test: add test case for previous --------- Co-authored-by: cuixiaorui <cui_xiaorui@126.com> * fix: prevent to the fix last incorrect word to the next Question page in Fix_Input mode * refactor: merge the prev and next question hook * fix: update bottom shortcuts tips style * fix: add dropdown background (#438) * feat: show tips when 3 times wrong (#440) * fix: add dropdown background * feat: show tips when 3 times wrong * fix: hide AnswerTip after correctAnswer * refactor: extraction function --------- Co-authored-by: cuixiaorui <cui_xiaorui@126.com> * fix: change the style of the prev/next question btn on the game page (#434) * fix: change the style of the prev/next question btn on the game page * fix: Change the position of the Prev/Next question btn on the game page * fix: Modify the style of the Previous/Next buttons * fix: verify whether shortcut keys are duplicated (#394) Co-authored-by: fengstats <feng2860984180@163.com> * fix: add typescript type checking to the handleEdit methd * fix: modify the base attribute to the typescript type * test: modify some case for the test file * test: add some expects * fix: shortcutKey unit test * fix: adjust home page and opt * fix: optimize statement directory list style (#449) Co-authored-by: fengstats <feng2860984180@163.com> * feat: home page last opt, add part func * fix: clear input value and focus input when statementIndex is first * fix: AnswerTip close correctly & always show close icon (#446) * fix: close tip correctly * feat: AnswerTip always show close icon * refactor: close answer tips --------- Co-authored-by: cuixiaorui <cui_xiaorui@126.com> * refactor: extraction function * fix: optimize style of shortcut keys (#443) Co-authored-by: fengstats <feng2860984180@163.com> * feat: show the course time and numbers on summary page (#312) * feat: show the course time on the share page and summary page * refactor: delete * refactor: course time --------- Co-authored-by: cuixiaorui <cui_xiaorui@126.com> * fix: adjust game page display (#456) * fix: adjust game page display * fix: zoom out AnswerTip width * feat: add day style and fix some style * fix: save the theme mode to localStorage (#468) * style: update border color of rank item in dark mode (#467) * test: add test cases for pronunciation (#464) * feat: Add click feedback to the previous and next question buttons. (#457) * fix: db upload error (#416) * perf: convert to Chinese * chore: update env example config & README file * docs: update Testing description * feat: Changed to Chinese, and added some daytime mode styles * feat: add dictation mode * refactor: move to components/home * refactor: remove commonBackTop on game page * test: fix e2e test --------- Co-authored-by: jiushi21 <zc931325671@gmail.com> Co-authored-by: tors <75771172+Torstentjh@users.noreply.github.com> Co-authored-by: cuixiaorui <cui_xiaorui@126.com> Co-authored-by: fengstats <feng2860984180@163.com> Co-authored-by: ReinerLau <103234074+ReinerLau@users.noreply.github.com> Co-authored-by: BaboonKing <changfan.xu.up@qq.com> Co-authored-by: nullcache <nullcache@outlook.com> Co-authored-by: 7ee <67595284+liigic@users.noreply.github.com> Co-authored-by: Hazel <52577448+Hazel-Lin@users.noreply.github.com> Co-authored-by: vampirewy <haveaballmyball@hotmail.com> Co-authored-by: wendZzoo <45628596+zuowendong@users.noreply.github.com> Co-authored-by: 小小石 <48991003+fengstats@users.noreply.github.com> Co-authored-by: Lee <159253237+LeeeChenn@users.noreply.github.com> Co-authored-by: o_qll <152288199+no-ov@users.noreply.github.com> Co-authored-by: zwd <17326195691@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #373
Related to #356