Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jump to specific statement #404

Merged
merged 10 commits into from
Mar 29, 2024
Merged

Conversation

ReinerLau
Copy link
Contributor

@ReinerLau ReinerLau commented Mar 28, 2024

  1. 目录的隐藏和显示

2024-03-28 1 18 41 PM

  1. 当前章节高亮

image

  1. 高性能虚拟滚动

2024-03-28 1 30 59 PM

  1. 章节快速定位

2024-03-28 1 35 27 PM

  1. 章节快速定位

2024-03-28 2 40 18 PM

  1. 区分已学未学(可选)(默认不区分)

image

@fengstats
Copy link
Collaborator

fengstats commented Mar 28, 2024

@ReinerLau 效果看起来很棒!

一些小问题

  1. 测试挂了,需要修复/调整/补充
  2. 目前最新代码中已经移除了 naive-ui 相关依赖,所以 <n-virtual-list> 组件需要寻找其他解决方案

查看:#179

@ReinerLau
Copy link
Contributor Author

ReinerLau commented Mar 28, 2024

@ReinerLau 效果看起来很棒!

一些小问题

  1. 测试挂了,需要修复/调整/补充
  2. 目前最新代码中已经移除了 naive-ui 相关依赖,所以 <n-virtual-list> 组件需要寻找其他解决方案

查看:#179

虚拟滚动改为使用 vueuse 内置的 hook

@cuixiaorui
Copy link
Contributor

感谢 pr
之前还想提这个需求呢
完成的非常 nice
不过功能 6 有点多余 需要干掉

这个功能的目的是为了让用户方便的切换题目 , 避免之前刷过的题目在重新刷一遍
所以我们不需要展示他有没有学过

@ReinerLau
Copy link
Contributor Author

ReinerLau commented Mar 28, 2024

感谢 pr 之前还想提这个需求呢 完成的非常 nice 不过功能 6 有点多余 需要干掉

这个功能的目的是为了让用户方便的切换题目 , 避免之前刷过的题目在重新刷一遍 所以我们不需要展示他有没有学过

意思是即使用户是第一遍刷的情况下也允许所有题目快速切换? @cuixiaorui

@cuixiaorui
Copy link
Contributor

对 允许

@fengstats
Copy link
Collaborator

related to #415

@cuixiaorui
Copy link
Contributor

🙏🏻感谢pr

我做了一些 refactor

  1. 删除了功能6
    该功能目前只关注一个点 就是方便让用户做跳转

  2. 删除了多余的注释
    注释只写 why , what 用函数的命名来表达就好

@cuixiaorui cuixiaorui merged commit 6a71533 into cuixueshe:main Mar 29, 2024
1 check passed
@ReinerLau ReinerLau deleted the feat/jump-to branch March 29, 2024 13:33
cuixiaorui added a commit that referenced this pull request Apr 3, 2024
* feat: home upgrade v0.1 (unfinished)

* feat: add PayCard.vue

* feat: opt home page header style, separate component

* feat: separate components

* feat: opt home style

* fix: index.vue commit import and fix Navbar.vue h1 style

* fix: Navbar.vue button

* feat: PayCard style feat and fix some question

* feat: feat some style

* feat: feat PayCard style

* feat: feat Questions style

* fix: delete more svg

* feat: add next button (#413)

* feat: addNextButton

* feat: addChangeSkipSetting

* refactor: skip

---------

Co-authored-by: cuixiaorui <cui_xiaorui@126.com>

* fix: Initialize the default shortcut key

* test: fix test case

* fix: rank Loading show position

* feat: jump to specific statement (#404)

* feat: to specific statement

* refactor: contents use virtual scroll

* feat: click contents outside then hide

* feat: save learned progress

* feat: content text line break

* refactor: change virtual scroll

* fix: unit test fetch history error

* feat: contents toogle mode

* refactor: contents on click outside

* refactor: detect whether the function is learned

---------

Co-authored-by: cuixiaorui <cui_xiaorui@126.com>

* chore: use .node-version to fixed node version (#374)

* feat: Answer page support Space next sentence

* feat: add to back  previous statement (#425)

* feat: addPreviousButton

* fix: VariableValue

* refactor: delete message

* test: add test case for previous

---------

Co-authored-by: cuixiaorui <cui_xiaorui@126.com>

* fix: prevent to the fix last incorrect word to the next Question page in Fix_Input mode

* refactor: merge the prev and next question hook

* fix: update bottom shortcuts tips style

* fix: add dropdown background (#438)

* feat: show tips when 3 times wrong (#440)

* fix: add dropdown background

* feat: show tips when 3 times wrong

* fix: hide AnswerTip after correctAnswer

* refactor: extraction function

---------

Co-authored-by: cuixiaorui <cui_xiaorui@126.com>

* fix: change the style of the prev/next question btn on the game page (#434)

* fix: change the style of the prev/next question btn on the game page

* fix: Change the position of the Prev/Next question btn on the game page

* fix: Modify the style of the Previous/Next buttons

* fix: verify whether shortcut keys are duplicated (#394)

Co-authored-by: fengstats <feng2860984180@163.com>

* fix: add typescript type checking to the handleEdit methd

* fix: modify the base  attribute to the typescript type

* test: modify some case for the test file

* test: add some expects

* fix: shortcutKey unit test

* fix: adjust home page and opt

* fix: optimize statement directory list style (#449)

Co-authored-by: fengstats <feng2860984180@163.com>

* feat: home page last opt, add part func

* fix: clear input value and focus input when statementIndex is first

* fix: AnswerTip close correctly & always show close icon (#446)

* fix: close tip correctly

* feat: AnswerTip always show close icon

* refactor: close answer tips

---------

Co-authored-by: cuixiaorui <cui_xiaorui@126.com>

* refactor: extraction function

* fix: optimize style of shortcut keys (#443)

Co-authored-by: fengstats <feng2860984180@163.com>

* feat: show the course time and numbers on summary page (#312)

* feat: show the course time on the share page and summary page

* refactor: delete

* refactor: course time

---------

Co-authored-by: cuixiaorui <cui_xiaorui@126.com>

* fix: adjust game page display (#456)

* fix: adjust game page display

* fix: zoom out AnswerTip width

* feat: add day style and fix some style

* fix: save the theme mode to localStorage (#468)

* style: update border color of rank item in dark mode (#467)

* test: add test cases for pronunciation (#464)

* feat: Add click feedback to the previous and next question buttons. (#457)

* fix: db upload error (#416)

* perf: convert to Chinese

* chore: update env example config & README file

* docs: update Testing description

* feat: Changed to Chinese, and added some daytime mode styles

* feat: add dictation mode

* refactor: move to components/home

* refactor:  remove commonBackTop on game page

* test: fix e2e test

---------

Co-authored-by: jiushi21 <zc931325671@gmail.com>
Co-authored-by: tors <75771172+Torstentjh@users.noreply.github.com>
Co-authored-by: cuixiaorui <cui_xiaorui@126.com>
Co-authored-by: fengstats <feng2860984180@163.com>
Co-authored-by: ReinerLau <103234074+ReinerLau@users.noreply.github.com>
Co-authored-by: BaboonKing <changfan.xu.up@qq.com>
Co-authored-by: nullcache <nullcache@outlook.com>
Co-authored-by: 7ee <67595284+liigic@users.noreply.github.com>
Co-authored-by: Hazel <52577448+Hazel-Lin@users.noreply.github.com>
Co-authored-by: vampirewy <haveaballmyball@hotmail.com>
Co-authored-by: wendZzoo <45628596+zuowendong@users.noreply.github.com>
Co-authored-by: 小小石 <48991003+fengstats@users.noreply.github.com>
Co-authored-by: Lee <159253237+LeeeChenn@users.noreply.github.com>
Co-authored-by: o_qll <152288199+no-ov@users.noreply.github.com>
Co-authored-by: zwd <17326195691@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants