Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralised reg parse should handle "./" better #4358

Closed
MetRonnie opened this issue Aug 13, 2021 · 2 comments · Fixed by #4441
Closed

Centralised reg parse should handle "./" better #4358

MetRonnie opened this issue Aug 13, 2021 · 2 comments · Fixed by #4441
Assignees
Labels
could be better Not exactly a bug, but not ideal.
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Aug 13, 2021

Follow-up to #4285

The centralised reg parse should recognise that ./<reg> means only look in cwd for <reg>, not in ~/cylc-run. But with #4285 you get an unnecessary warning:

$ cd ~/cylc-src
$ cylc validate ./armageddon 
WARNING - The specified reg could refer to ./armageddon/flow.cylc or ~/cylc-run/armageddon/run1/flow.cylc.
This command will use ./armageddon/flow.cylc.
@MetRonnie MetRonnie self-assigned this Aug 13, 2021
@MetRonnie MetRonnie added the could be better Not exactly a bug, but not ideal. label Aug 13, 2021
@MetRonnie MetRonnie added this to the cylc-8.0b3 milestone Aug 13, 2021
@MetRonnie
Copy link
Member Author

Also, (and note this is slightly different problem), if the cwd is ~/cylc-run/, then sometimes it still gives the warning message despite the fact that ./darmok/flow.cylc and ~/cylc-run/darmok/flow.cylc are the same file in that case. This may be due to our Met Office filesystem where /net/home/ and /home/ are the same.

@MetRonnie
Copy link
Member Author

This can probably be bumped to the 8.0rc1 milestone, or even 8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant