Infer run number & centralised reg parse #4285

MetRonnie · 2021-06-30T11:41:26Z

These changes close #4230 and close #3895

The cylc.flow.workflow_files.parse_reg() function provides a centralised way to process the REG or WORKFLOW arg in cylc commands.
Using this function provides inference of the latest run number, so instead of having to type cylc pause foo/run3 you can do cylc pause foo assuming run3 is the latest (also if you do foo/runN it processes this as foo/run3)
"Offline" commands that work using a workflow file (or any file actually) need to use parse_reg(reg, src=True). With src=True the reg can be:
- a path to an existing file or a dir containing a flow.cylc file (either absolute, or relative to PWD, or relative to ~/cylc-run (PWD takes precedence¹))
"Online" commands that work by using graphQL/detecting workflow contact, need to use src=False (the default). With src=False the reg can be:
- a path relative to ~/cylc-run only (the dir need not exist but it can't be a path to a file)

Requirements check-list

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Applied any dependency changes to both setup.py and
conda-environment.yml.
Appropriate tests are included (unit).
Appropriate change log entry included.
(master branch) I have opened a documentation PR at cylc/cylc-doc/pull/XXXX.

This is a change in behaviour. Previously it was the case that the path relative to ~/cylc-run took precedence over PWD, apart from . for PWD itself, strangely. See #4285 (comment) and #4285 (comment) ↩

cylc/flow/workflow_files.py

MetRonnie · 2021-06-30T15:40:13Z

One consequence of this change is that the "offline" commands no longer accept paths to a file relative to PWD. Any relative path is interpreted as relative to ~/cylc-run (apart from ., which is kept as PWD). Does this need to be changed back to the original behaviour?

oliver-sanders

One consequence of this change is that the "offline" commands no longer accept paths to a file relative to PWD.
...
Does this need to be changed back to the original behaviour?

Hmm, it is kinda nasty accepting a path that is either relative to $PWD or ~/cylc-run, however, this has worked for us before. This interface accepts . which is interpreted relative to $PWD so not accepting ./foo/ or foo/ would be counter intuitive.

Options:

Don't allow paths relative to $PWD but make an exception for . (implemented.
Allow paths relative to $PWD, check $PWD before ~/cylc-run.
Allow paths relative to $PWD, check ~/cylc-run before $PWD.
Allow paths relative to $PWD but enforce them to begin with . (e.g. ./foo/).

Cons:

1: Counter intuitive.

$ cd cylc-src/foo
$ cylc validate .
ok
$ cd cylc-src
$ cylc validate ./foo
error

2&3: Has the potential for unexpected results:

$ cd ~/cylc-src/
$ cylc install foo
$ cylc validate foo  # is this validating the src or the run copy?

4: Counter intuitive.

$ cd ~/cylc-src
$ ls foo
flow.cylc
$ cylc validate foo
error

oliver-sanders · 2021-07-01T10:18:46Z

cylc/flow/platforms.py

@@ -548,5 +564,5 @@ def get_random_platform_for_install_target(

 def get_localhost_install_target() -> str:
    """Returns the install target of localhost platform"""
-    localhost = platform_from_name()
+    localhost = get_platform()


@wxtim can you check this.

This is just changing it back to how it was before; both identical as can be seen from def get_platform(task_conf=None, task_id=UNKNOWN_TASK):

cylc-flow/cylc/flow/platforms.py

Lines 85 to 87 in bc72520

if task_conf is None or isinstance(task_conf, str):

# task_conf is a platform name, or get localhost if None

return platform_from_name(task_conf)

The reason I had previously changed it to platform_from_name() was because mypy was complaining that localhost might be None due to the Optional return of get_platform(). However this now is fixed by the use of @overload to confirm that if task_conf is None, the return value will definitely be a dictionary

cylc-flow/cylc/flow/platforms.py

Lines 43 to 47 in bc72520

@overload

def get_platform(

task_conf: Union[str, None] = None, task_id: str = UNKNOWN_TASK

) -> Dict[str, Any]:

...

I've just found out about a nasty omission in mypy's checking of @overloaded function implementations: python/mypy#9503

cylc/flow/scheduler_cli.py

oliver-sanders · 2021-07-01T10:37:25Z

cylc/flow/scripts/edit.py

-def main(parser, options, *args):
-    flow_file = parse_workflow_arg(options, args[0])[1]
+def main(parser: COP, options: 'Values', reg: str) -> None:
+    flow_file = str(parse_reg(reg, src=True)[1])


Is this str needed?

Not 100% sure but the variable was previously a string, so I think I did this to be safe in case something further down doesn't like using pathlib Paths instead of strings

oliver-sanders · 2021-07-01T10:44:19Z

cylc/flow/scripts/search.py

                curr_file = os.path.join(workflowdir, inc_file)
                line_no = inc_line_count
            else:
-                curr_file = flow_file
+                curr_file = str(flow_file)


Is this str necessary?

cylc/flow/workflow_files.py

MetRonnie · 2021-07-02T15:51:34Z

@hjoliver I've tagged you in case you want to respond to any of the discussion on this, you don't need to review the code necessarily

hjoliver · 2021-07-05T06:41:38Z

One consequence of this change is that the "offline" commands no longer accept paths to a file relative to PWD.
...
Hmm, it is kinda nasty accepting a path that is either relative to $PWD or ~/cylc-run, however, this has worked for us before. This interface accepts . which is interpreted relative to $PWD so not accepting ./foo/ or foo/ would be counter intuitive.

Options:

Don't allow paths relative to $PWD but make an exception for . (implemented.

Allow paths relative to $PWD, check $PWD before ~/cylc-run.

Allow paths relative to $PWD, check ~/cylc-run before $PWD.

Allow paths relative to $PWD but enforce them to begin with . (e.g. ./foo/).

IMO it has to be 2. because non-absolute paths are expected be relative to $PWD as a general principle. To break that in this case would definitely be counterintuitive and surprising for many users.

oliver-sanders · 2021-07-05T10:58:08Z

IMO it has to be 2

Agreed, however, we could do with handling the ambiguity.

It's easy enough to detect the cases where the user could be referring either to a flow relative to cylc-run or $PWD (excluding the case where $PWD == ~/cylc-run) and log a warning.

Slightly nasty as I don't think we have a way of forcing Cylc to pick the run copy in this eventuality.

With universal-id they could achieve this by prefixing the user name on:

$ cylc validate ~user/foo

oliver-sanders

Code looks good, thanks for the docstrings and for getting your head around what turned out to be a much more complex logic than expected!

Codacy has highlighted a few error cases which aren't covered by the tests, would be good to cover a few of them if possible.

Functional testing has mostly gone well, a few small issues:

I think this is tricking cylc clean into thinking that the workflow is stopped.

To replicate try:

cylc install one; cylc play one; tree -a ~/cylc-run; cylc clean one; tree -a ~/cylc-run

This should confirm that the contact file is present when the clean command is run.

On a network filesystem I get the expected error when you remove a dir where a running process has an open file handle:

FileRemovalError: [Errno 39] Directory not empty: 'workflow'. This is probably a temporary issue with the filesystem, not a problem with Cylc.

Traceback for cylc clean.

This might be unrelated, further attempts to clean the workflow in (1) resulted in traceback:

$ cylc cleal one
INFO - No workflow database - will only clean locally
INFO - Cleaning on local filesystem
Traceback (most recent call last):
...
OSError: [Errno 16] Device or resource busy: '.nfsc0000207034ffdad00000025'

I couldn't replicate this every time.

Duplicate warnings for suite.rc deprecation

$ cylc validate ./whatever
WARNING - The filename 'suite.rc' is deprecated in favour of 'flow.cylc'
WARNING - The filename 'suite.rc' is deprecated in favour of 'flow.cylc'

(where whatever also exists in the cylc-run directory)

Ambiguity where it isn't needed

(small issue, not a biggie, can punt to future work if it isn't a quick fix)

If I have the following setup:

~/
    cylc-src/
        whatever
    cylc-run/
        whatever

And try to validate the source workflow like so:

$ cd ~/cylc-src
$ cylc validate whatever

I get the expected warning due to ambiguity:

WARNING - Workflow files found in both ./whatever/suite.rc and /home/me/cylc-run/whatever/run1/flow.cylc. This command will use ./whatever/suite.rc.

However, if I prepend ./ to the flow name there shouldn't be any ambiguity any more, however, I still get the warning.

$ cd ~/cylc-src
$ cylc validate ./whatever

cylc/flow/templatevars.py

oliver-sanders · 2021-08-10T08:55:18Z

cylc/flow/workflow_files.py

+    if not src:
+        validate_workflow_name(reg)
+    reg: Path = Path(expand_path(reg))


Should the expand path come before the validate?

I think validate_workflow_name() is designed to validate what the user has typed verbatim, so we don't want to normalise/expand/etc it until after

oliver-sanders · 2021-08-10T09:40:16Z

cylc/flow/workflow_files.py

+REG_CLASH_MSG = (
+    "Workflow files found in both {0} and {1}. This command will use {0}."
+)


This message could be a little clearer.

What do you have in mind?

I suppose I can change {1} from being /home/blah/blah/user/cylc-run/<run_dir> to just ~/cylc-run/<run_dir>, but I'm guessing that's not what you mean

Not sure I had anything particular in mind.

I think "Workflow files" surprised me a little, might not be so obvious to a user that this implies a reference ambiguity between a src and run dir.

{input} could mean {src_dir} or ~/cylc-run/{run_dir.relative_to(cylc_run_dir)}, using {src_dir} # ???

I suppose I can change {1} from being /home/blah/blah/user/cylc-run/<run_dir> to just ~/cylc-run/<run_dir>

Would be good.

MetRonnie · 2021-08-10T10:22:56Z

I think this is tricking cylc clean into thinking that the workflow is stopped.

This should be fixed by #4289

Traceback for cylc clean.

This seems to happen (on NFS) the second time shutil.rmtree() is called on a dir that it failed for the first time round due to a file still being open inside. I have spent a little bit of time trying to find a solution as a follow-up to #4133, but not managed
to yet. See also #3659

MetRonnie · 2021-08-12T11:43:32Z

Duplicate warnings for suite.rc deprecation

Addressed in latest push

Ambiguity where it isn't needed

Will open a new issue

oliver-sanders · 2021-08-12T14:31:17Z

I think this is tricking cylc clean into thinking that the workflow is stopped.

This should be fixed by #4289

Confirmed as fixed.

Traceback for cylc clean.

This seems to happen (on NFS) the second time shutil.rmtree ... trying to find a solution as a follow-up to #4133, but not managed to yet. See also #3659

That's fine, lets bump it to #3659

Although is this fix not related - MetRonnie@b02d74f?

Duplicate warnings for suite.rc deprecation

Addressed in latest push

Confirmed as fixed.

Ambiguity where it isn't needed

Will open a new issue

👍

oliver-sanders · 2021-08-12T14:33:18Z

I've found one more small issue, this time with the reinstall command which gives a really confusing traceback talking about run1 rather than run2:

$ cylc install one
...
$ cylc install one
...
$ cylc reinstall one
WorkflowFilesError: Nested run directories not allowed - cannot install workflow name "one" as "/home/me/cylc-run/one/run1" is already a valid run directory.

Although I'm not convinced that is necessarily to do with the reg parsing?

Can bump if not related.

MetRonnie · 2021-08-13T09:43:59Z

This seems to happen (on NFS) the second time shutil.rmtree ... trying to find a solution as a follow-up to #4133, but not managed to yet. See also #3659

Although is this fix not related - MetRonnie/cylc-flow@b02d74f?

Yes - I've been having a bit of a go at improving that rmtree error handler

I've found one more small issue, this time with the reinstall command

I can reproduce on master. (reinstall isn't using the centralised reg parse)

oliver-sanders · 2021-08-13T10:04:55Z

I can reproduce on master

Ok, I'll open a separate issue.

(reinstall isn't using the centralised reg parse)

Ah, it should be because it's working with workflow identifiers (run dir only).

MetRonnie · 2021-08-13T10:07:28Z

In that case, could you add "make it use the centralised reg parse" to that issue please?

oliver-sanders · 2021-08-13T12:41:50Z

In that case, could you add "make it use the centralised reg parse" to that issue please?

But then we wouldn't be able to close the issues and would have mixed behaviour?

Seems straightforward to convert, this did the trick for me:

(note this also solves the traceback reported above due to inferring the run number)

diff --git a/cylc/flow/scripts/reinstall.py b/cylc/flow/scripts/reinstall.py
index b25e2af23..1653b5861 100644
--- a/cylc/flow/scripts/reinstall.py
+++ b/cylc/flow/scripts/reinstall.py
@@ -45,9 +45,11 @@ from cylc.flow.exceptions import PluginError, WorkflowFilesError
 from cylc.flow.option_parsers import CylcOptionParser as COP
 from cylc.flow.pathutil import get_workflow_run_dir
 from cylc.flow.workflow_files import (
+    WorkflowFiles,
     get_workflow_source_dir,
+    parse_reg,
     reinstall_workflow,
-    WorkflowFiles)
+)
 from cylc.flow.terminal import cli_function
 
 if TYPE_CHECKING:
@@ -112,26 +114,20 @@ def get_option_parser():
 
 @cli_function(get_option_parser)
 def main(
-    parser: COP, opts: 'Values', named_run: Optional[str] = None
+        parser: COP, opts: 'Values', workflow: str
 ) -> None:
-    if not named_run:
-        source, _ = get_workflow_source_dir(Path.cwd())
-        if source is None:
-            raise WorkflowFilesError(
-                f'"{Path.cwd()}" is not a workflow run directory.')
-        base_run_dir = Path(get_workflow_run_dir(''))
-        named_run = str(Path.cwd().relative_to(base_run_dir.resolve()))
-    run_dir = Path(get_workflow_run_dir(named_run))
+    workflow = parse_reg(workflow)
+    run_dir = Path(get_workflow_run_dir(workflow))
     if not run_dir.exists():
         raise WorkflowFilesError(
-            f'"{named_run}" is not an installed workflow.')
+            f'"{workflow}" is not an installed workflow.')
     if run_dir.name in [WorkflowFiles.FLOW_FILE, WorkflowFiles.SUITE_RC]:
         run_dir = run_dir.parent
-        named_run = named_run.rsplit('/', 1)[0]
+        workflow = workflow.rsplit('/', 1)[0]
     source, source_path = get_workflow_source_dir(run_dir)
     if not source:
         raise WorkflowFilesError(
-            f'"{named_run}" was not installed with cylc install.')
+            f'"{workflow}" was not installed with cylc install.')
     if not Path(source).exists():
         raise WorkflowFilesError(
             f'Workflow source dir is not accessible: "{source}".\n'
@@ -153,7 +149,7 @@ def main(
             ) from None
 
     reinstall_workflow(
-        named_run=named_run,
+        named_run=workflow,
         rundir=run_dir,
         source=source,
         dry_run=False  # TODO: ready for dry run implementation

Functional test alterations:

removes test cases which no longer make sense:

workflow arg ending in (flow.cylc|suite.rc) not supported by other commands.

nested run dir detection, install now prevents this, would have to manually fudge it.

diff --git a/tests/functional/cylc-reinstall/00-simple.t b/tests/functional/cylc-reinstall/00-simple.t
index 83287a4bd..a5bb6c2c1 100644
--- a/tests/functional/cylc-reinstall/00-simple.t
+++ b/tests/functional/cylc-reinstall/00-simple.t
@@ -18,7 +18,7 @@
 #------------------------------------------------------------------------------
 # Test workflow re-installation
 . "$(dirname "$0")/test_header"
-set_test_number 36
+set_test_number 18
 
 # Test basic cylc reinstall, named run given
 TEST_NAME="${TEST_NAME_BASE}-basic-named-run"
@@ -35,36 +35,6 @@ grep_ok "REINSTALLED ${RND_WORKFLOW_NAME}/run1 from ${RND_WORKFLOW_SOURCE}" "${R
 popd || exit 1
 purge_rnd_workflow
 
-# Test basic cylc reinstall, named run (including ``flow.cylc``) given
-TEST_NAME="${TEST_NAME_BASE}-flow-as-arg"
-make_rnd_workflow
-pushd "${RND_WORKFLOW_SOURCE}" || exit 1
-run_ok "${TEST_NAME}" cylc install
-run_ok "${TEST_NAME}-reinstall" cylc reinstall "${RND_WORKFLOW_NAME}/run1/flow.cylc"
-contains_ok "${TEST_NAME}.stdout" <<__OUT__
-INSTALLED $RND_WORKFLOW_NAME/run1 from ${RND_WORKFLOW_SOURCE}
-__OUT__
-REINSTALL_LOG="$(find "${RND_WORKFLOW_RUNDIR}/run1/log/install" -type f -name '*reinstall.log')"
-grep_ok "REINSTALLED ${RND_WORKFLOW_NAME}/run1 from ${RND_WORKFLOW_SOURCE}" "${REINSTALL_LOG}"
-popd || exit 1
-purge_rnd_workflow
-
-# Test basic cylc reinstall, named run (including suite.rc) given
-TEST_NAME="${TEST_NAME_BASE}-suite.rc-as-arg"
-make_rnd_workflow
-pushd "${RND_WORKFLOW_SOURCE}" || exit 1
-rm -rf flow.cylc
-touch suite.rc
-run_ok "${TEST_NAME}" cylc install
-run_ok "${TEST_NAME}-reinstall-suite.rc" cylc reinstall "${RND_WORKFLOW_NAME}/run1/suite.rc"
-contains_ok "${TEST_NAME}.stdout" <<__OUT__
-INSTALLED $RND_WORKFLOW_NAME/run1 from ${RND_WORKFLOW_SOURCE}
-__OUT__
-REINSTALL_LOG="$(find "${RND_WORKFLOW_RUNDIR}/run1/log/install" -type f -name '*reinstall.log')"
-grep_ok "REINSTALLED ${RND_WORKFLOW_NAME}/run1 from ${RND_WORKFLOW_SOURCE}" "${REINSTALL_LOG}"
-popd || exit 1
-purge_rnd_workflow
-
 # Test install/reinstall executed from elsewhere in filesystem
 TEST_NAME="${TEST_NAME_BASE}-named-flow"
 make_rnd_workflow
@@ -116,38 +86,4 @@ grep_ok "The filename 'suite.rc' is deprecated in favour of 'flow.cylc'. Symlink
 popd || exit 1
 purge_rnd_workflow
 
-# Test cylc reinstall from within rundir, no args given
-TEST_NAME="${TEST_NAME_BASE}-no-args"
-make_rnd_workflow
-run_ok "${TEST_NAME}-install" cylc install --flow-name="${RND_WORKFLOW_NAME}" -C "${RND_WORKFLOW_SOURCE}"
-contains_ok "${TEST_NAME}-install.stdout" <<__OUT__
-INSTALLED ${RND_WORKFLOW_NAME}/run1 from ${RND_WORKFLOW_SOURCE}
-__OUT__
-pushd "${RND_WORKFLOW_RUNDIR}/run1" || exit 1
-touch "${RND_WORKFLOW_SOURCE}/new_file"
-run_ok "${TEST_NAME}-reinstall" cylc reinstall
-REINSTALL_LOG="$(find "${RND_WORKFLOW_RUNDIR}/run1/log/install" -type f -name '*reinstall.log')"
-grep_ok "REINSTALLED ${RND_WORKFLOW_NAME}/run1 from ${RND_WORKFLOW_SOURCE}" "${REINSTALL_LOG}"
-exists_ok new_file
-popd || exit 1
-purge_rnd_workflow
-
-# Test cylc reinstall from within rundir, no args given
-TEST_NAME="${TEST_NAME_BASE}-no-args-no-run-name"
-make_rnd_workflow
-pushd "${RND_WORKFLOW_SOURCE}" || exit 1
-run_ok "${TEST_NAME}-install" cylc install --no-run-name -C "${RND_WORKFLOW_SOURCE}"
-contains_ok "${TEST_NAME}-install.stdout" <<__OUT__
-INSTALLED ${RND_WORKFLOW_NAME} from ${RND_WORKFLOW_SOURCE}
-__OUT__
-pushd "${RND_WORKFLOW_RUNDIR}" || exit 1
-touch "${RND_WORKFLOW_SOURCE}/new_file"
-run_ok "${TEST_NAME}-reinstall" cylc reinstall
-REINSTALL_LOG="$(find "${RND_WORKFLOW_RUNDIR}/log/install" -type f -name '*reinstall.log')"
-grep_ok "REINSTALLED ${RND_WORKFLOW_NAME} from ${RND_WORKFLOW_SOURCE}" "${REINSTALL_LOG}"
-exists_ok new_file
-popd || exit 1
-popd || exit 1
-purge_rnd_workflow
-
 exit
diff --git a/tests/functional/cylc-reinstall/02-failures.t b/tests/functional/cylc-reinstall/02-failures.t
index e81ae00a2..da327270a 100644
--- a/tests/functional/cylc-reinstall/02-failures.t
+++ b/tests/functional/cylc-reinstall/02-failures.t
@@ -18,20 +18,7 @@
 #------------------------------------------------------------------------------
 # Test workflow reinstallation expected failures
 . "$(dirname "$0")/test_header"
-set_test_number 26
-
-# Test fails is there is a nested run directory structure in the run directory to be reinstalled
-
-TEST_NAME="${TEST_NAME_BASE}-nested-rundir-forbidden-reinstall"
-make_rnd_workflow
-run_ok "${TEST_NAME}-install" cylc install -C "${RND_WORKFLOW_SOURCE}" --flow-name="${RND_WORKFLOW_NAME}"
-mkdir "${RND_WORKFLOW_RUNDIR}/run1/nested_run_dir"
-touch "${RND_WORKFLOW_RUNDIR}/run1/nested_run_dir/flow.cylc"
-run_fail "${TEST_NAME}-reinstall-nested-run-dir" cylc reinstall "${RND_WORKFLOW_NAME}"
-contains_ok "${TEST_NAME}-reinstall-nested-run-dir.stderr" <<__ERR__
-WorkflowFilesError: Nested run directories not allowed - cannot install workflow name "${RND_WORKFLOW_NAME}" as "${RND_WORKFLOW_RUNDIR}/run1" is already a valid run directory.
-__ERR__
-purge_rnd_workflow
+set_test_number 20
 
 # Test fail no workflow source dir
 
@@ -86,22 +73,6 @@ __ERR__
     popd || exit 1
 done
 
-# Test cylc reinstall (no args given) raises error when no source dir.
-TEST_NAME="${TEST_NAME_BASE}-reinstall-no-source-rasies-error"
-make_rnd_workflow
-pushd "${RND_WORKFLOW_SOURCE}" || exit 1
-run_ok "${TEST_NAME}-install" cylc install --no-run-name --flow-name="${RND_WORKFLOW_NAME}"
-pushd "${RND_WORKFLOW_RUNDIR}" || exit 1
-rm -rf "_cylc-install"
-run_fail "${TEST_NAME}-reinstall" cylc reinstall
-CWD=$(pwd -P)
-contains_ok "${TEST_NAME}-reinstall.stderr" <<__ERR__
-WorkflowFilesError: "${CWD}" is not a workflow run directory.
-__ERR__
-popd || exit 1
-popd || exit 1
-purge_rnd_workflow
-
 # Test cylc reinstall (args given) raises error when no source dir.
 TEST_NAME="${TEST_NAME_BASE}-reinstall-no-source-rasies-error2"
 make_rnd_workflow

oliver-sanders

Have tested the reinstall changes, works great.

No more issues from testing, great improvement, good to go 🎉.

datamel · 2021-08-17T12:56:27Z

No more issues from testing, great improvement, good to go 🎉.

Excellent, I'm back reviewing this and will merge once tested.

datamel

I've read through the code, run the tests locally and had a manual test with the change. No problems found. Thanks @MetRonnie.

Fix mixed use of alias in cylc cycle-point help

fe9418b

MetRonnie added this to the cylc-8.0b2 milestone Jun 30, 2021

MetRonnie requested a review from oliver-sanders June 30, 2021 11:41

MetRonnie self-assigned this Jun 30, 2021

MetRonnie commented Jun 30, 2021

View reviewed changes

cylc/flow/workflow_files.py Outdated Show resolved Hide resolved

MetRonnie commented Jun 30, 2021

View reviewed changes

cylc/flow/workflow_files.py Outdated Show resolved Hide resolved

MetRonnie force-pushed the centralised-reg-parse branch from 3818764 to 53988d1 Compare June 30, 2021 13:32

MetRonnie force-pushed the centralised-reg-parse branch from 53988d1 to bc72520 Compare June 30, 2021 15:53

MetRonnie changed the title ~~Centralised reg parse~~ Infer run number & centralised reg parse Jun 30, 2021

MetRonnie marked this pull request as ready for review June 30, 2021 17:02

MetRonnie requested review from hjoliver and datamel June 30, 2021 17:03

oliver-sanders reviewed Jul 1, 2021

View reviewed changes

MetRonnie force-pushed the centralised-reg-parse branch from 5a3d081 to eb9e3ce Compare July 1, 2021 15:43

MetRonnie added 5 commits July 1, 2021 16:51

Centralise both parsing of REG and inference of run number

2fbfda7

Type annotations & homogenise "[OPTIONS] ARGS" in script docstrings

50cbe95

Fix functional tests

70673f1

Update changelog

007c3e2

Remove unecessary require_flow_file arg from workflow_files.parse_reg()

1a9e119

MetRonnie force-pushed the centralised-reg-parse branch from eb9e3ce to 1a9e119 Compare July 1, 2021 15:53

MetRonnie removed the request for review from hjoliver July 2, 2021 15:51

MetRonnie marked this pull request as draft July 12, 2021 13:25

MetRonnie added 3 commits July 15, 2021 11:19

Merge branch 'master' into centralised-reg-parse

135ab1a

Create get_cylc_run_dir() function

7c1ce36

Allow parse_reg to use relative paths when src=True

7c6721d

MetRonnie force-pushed the centralised-reg-parse branch from 742f70a to c1205dc Compare July 16, 2021 16:20

MetRonnie force-pushed the centralised-reg-parse branch from fd1d6cc to c95baf5 Compare July 30, 2021 09:49

MetRonnie added 2 commits August 4, 2021 18:28

Merge branch 'master' into tmp

9b68a87

Update changelog

fc44f5d

MetRonnie force-pushed the centralised-reg-parse branch from c95baf5 to fc44f5d Compare August 4, 2021 17:31

oliver-sanders requested changes Aug 10, 2021

View reviewed changes

oliver-sanders reviewed Aug 10, 2021

View reviewed changes

Address code review

d1d44c9

Merge branch 'master' into centralised-reg-parse

32f8f64

MetRonnie force-pushed the centralised-reg-parse branch from d2dc35b to 32f8f64 Compare August 12, 2021 12:12

Clarify warning msg in response to code review

8fdec12

MetRonnie mentioned this pull request Aug 13, 2021

Centralised reg parse should handle "./" better #4358

Closed

Tweak reinstall to partially use centralised reg parse

a932ce6

MetRonnie force-pushed the centralised-reg-parse branch from 5e0d240 to a932ce6 Compare August 13, 2021 17:08

MetRonnie requested a review from datamel August 13, 2021 17:13

oliver-sanders mentioned this pull request Aug 16, 2021

tutorial: re-write for cylc8 cylc/cylc-doc#218

Closed

Merge branch 'master' into centralised-reg-parse

56cc652

oliver-sanders approved these changes Aug 16, 2021

View reviewed changes

datamel approved these changes Aug 19, 2021

View reviewed changes

datamel merged commit c6f7344 into cylc:master Aug 19, 2021

MetRonnie deleted the centralised-reg-parse branch August 19, 2021 12:54

MetRonnie mentioned this pull request Sep 29, 2021

parse_reg(): Avoid unnecessary reg clash messages #4441

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Infer run number & centralised reg parse #4285

Infer run number & centralised reg parse #4285

MetRonnie commented Jun 30, 2021 •

edited

Loading

MetRonnie commented Jun 30, 2021

oliver-sanders left a comment

oliver-sanders Jul 1, 2021

MetRonnie Jul 1, 2021 •

edited

Loading

MetRonnie Jul 1, 2021

oliver-sanders Jul 1, 2021

MetRonnie Jul 1, 2021

oliver-sanders Jul 1, 2021

MetRonnie commented Jul 2, 2021

hjoliver commented Jul 5, 2021 •

edited

Loading

oliver-sanders commented Jul 5, 2021

oliver-sanders left a comment •

edited

Loading

oliver-sanders Aug 10, 2021

MetRonnie Aug 10, 2021

oliver-sanders Aug 10, 2021

MetRonnie Aug 10, 2021

oliver-sanders Aug 12, 2021 •

edited

Loading

MetRonnie commented Aug 10, 2021 •

edited

Loading

MetRonnie commented Aug 12, 2021 •

edited

Loading

oliver-sanders commented Aug 12, 2021 •

edited

Loading

oliver-sanders commented Aug 12, 2021 •

edited

Loading

MetRonnie commented Aug 13, 2021

oliver-sanders commented Aug 13, 2021

MetRonnie commented Aug 13, 2021 •

edited

Loading

oliver-sanders commented Aug 13, 2021 •

edited

Loading

oliver-sanders left a comment

datamel commented Aug 17, 2021

datamel left a comment

	if task_conf is None or isinstance(task_conf, str):
	# task_conf is a platform name, or get localhost if None
	return platform_from_name(task_conf)

	@overload
	def get_platform(
	task_conf: Union[str, None] = None, task_id: str = UNKNOWN_TASK
	) -> Dict[str, Any]:
	...

Infer run number & centralised reg parse #4285

Infer run number & centralised reg parse #4285

Conversation

MetRonnie commented Jun 30, 2021 • edited Loading

Footnotes

MetRonnie commented Jun 30, 2021

oliver-sanders left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MetRonnie Jul 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MetRonnie commented Jul 2, 2021

hjoliver commented Jul 5, 2021 • edited Loading

oliver-sanders commented Jul 5, 2021

oliver-sanders left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oliver-sanders Aug 12, 2021 • edited Loading

Choose a reason for hiding this comment

MetRonnie commented Aug 10, 2021 • edited Loading

MetRonnie commented Aug 12, 2021 • edited Loading

oliver-sanders commented Aug 12, 2021 • edited Loading

oliver-sanders commented Aug 12, 2021 • edited Loading

MetRonnie commented Aug 13, 2021

oliver-sanders commented Aug 13, 2021

MetRonnie commented Aug 13, 2021 • edited Loading

oliver-sanders commented Aug 13, 2021 • edited Loading

oliver-sanders left a comment

Choose a reason for hiding this comment

datamel commented Aug 17, 2021

datamel left a comment

Choose a reason for hiding this comment

MetRonnie commented Jun 30, 2021 •

edited

Loading

MetRonnie Jul 1, 2021 •

edited

Loading

hjoliver commented Jul 5, 2021 •

edited

Loading

oliver-sanders left a comment •

edited

Loading

oliver-sanders Aug 12, 2021 •

edited

Loading

MetRonnie commented Aug 10, 2021 •

edited

Loading

MetRonnie commented Aug 12, 2021 •

edited

Loading

oliver-sanders commented Aug 12, 2021 •

edited

Loading

oliver-sanders commented Aug 12, 2021 •

edited

Loading

MetRonnie commented Aug 13, 2021 •

edited

Loading

oliver-sanders commented Aug 13, 2021 •

edited

Loading