-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse_reg()
: Avoid unnecessary reg clash messages
#4441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
cylc/flow/workflow_files.py
Outdated
@@ -1169,10 +1169,11 @@ def parse_reg(reg: str, src: bool = False, warn_depr=True) -> Tuple[str, Path]: | |||
""" | |||
if not src: | |||
validate_workflow_name(reg) | |||
cur_dir = reg.startswith(f'{os.curdir}{os.sep}') # if starts with './' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cur_dir
doesn't really match a data type of boolean IMO.
It's a bit of a mouthful, but I thing reg_is_curdir
might be more helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read and happy
- Tried it locally
Made a small written communication suggestion. Matter of opinion which shouldn't stand in the way of merger if you wish to leave as is.
(Do remember to wait for the tests to pass before merging - in this case failing due to flakiness so ok) |
I was confident that they would pass after the change you had made, because the change was not significant, and they passed before. |
These changes close #4358
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
.