cli: provide full traceback with --debug #4181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(will do the changelog once b1 is out) |
oliver-sanders
force-pushed
the
cli-traceback
branch
from
6f7bd12
to
b72ef4a
Compare
MetRonnie
approved these changes
Apr 20, 2021
Comment on lines
+254
to
+263
| # catch "known" CylcErrors which should have sensible short | ||
| # summations of the issue, full traceback not necessary | ||
| print( | ||
| EXC_EXIT.format( | ||
| name=exc.__class__.__name__, | ||
| exc=exc | ||
| ), | ||
| file=sys.stderr | ||
| ) | ||
| sys.exit(1) |
There was a problem hiding this comment.
(Note to self, really) Ah, so this is called when commands other than cylc play raise, or if an exception occurs in scheduler_cli before it runs the scheduler - the scheduler has its own error logging logic
Question: Should I update #4180 so that if --debug is used, the scheduler will print out the full traceback for CylcErrors too?
There was a problem hiding this comment.
Would be nice if the scheduler dumped full traceback in --debug mode (can be helpful sometimes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always display full traceback unless the command is running interactively AND the error is an expected one (i.e. a subclass of
CylcError,ParsecError) BUT we are not in--debugmode.In this one case formatting a nice friendly error message for the user is much nicer.
That was the intention but unfortunately it wasn't quite implemented right so here's a fix and a test to go with it.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.