Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: verbosity #4214

Merged
merged 9 commits into from
May 17, 2021
Merged

cli: verbosity #4214

merged 9 commits into from
May 17, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented May 14, 2021

Addresses: #2972 (point 9)
Superseedes: #4181

  • Unify, --verbose, --quiet, --debug and make them global.
  • Format exceptions nicely unless verbosity > 1 (--debug or -v -v) in which case write the full traceback.

Side effects:

  • The CYLC_VERBOSE env var is now exported in job scripts (can change if we don't like this).

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

* left-align cylc tagline
* fix cylc play description (spanned two lines)
* improve formatting
@oliver-sanders oliver-sanders added this to the cylc-8.0b2 milestone May 14, 2021
@oliver-sanders oliver-sanders self-assigned this May 14, 2021
* all three are now a single flag/configuration
* translation between cli/flags/env is now centralised
* connection info written in verbose mode was going to stdout
Comment on lines 47 to 50
Start, restart or resume a workflow.

Start running a workflow, or restart a stopped workflow from its previous
state, or resume a paused workflow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho, might as well delete the second paragraph in that case

cylc/flow/option_parsers.py Show resolved Hide resolved
cylc/flow/parsec/example/test.py Outdated Show resolved Hide resolved
cylc/flow/scripts/validate.py Outdated Show resolved Hide resolved
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
USAGE = f"""{cylc_header()}
{centered(DESC)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(good move 👍 )

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@hjoliver hjoliver merged commit 82ada2e into cylc:master May 17, 2021
@oliver-sanders oliver-sanders deleted the cli-verbosity branch May 17, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants