Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc clean 3: targeted clean #4237

Merged
merged 22 commits into from
Jun 29, 2021
Merged

cylc clean 3: targeted clean #4237

merged 22 commits into from
Jun 29, 2021

Commits on Jun 2, 2021

  1. Type annotations

    MetRonnie committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    988648f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    506bb38 View commit details
    Browse the repository at this point in the history
  3. Fix & refactor cylc clean unit tests

    Add test for --remote-only option too
    MetRonnie committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    eacdcce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a037073 View commit details
    Browse the repository at this point in the history
  5. Fix error when share/cycle sylink dir same as share

    Also changed notation of symlink stuff from dst/src to path/target, because I get really confused by dst/src!
    MetRonnie committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    505b27b View commit details
    Browse the repository at this point in the history
  6. Allow symlink dirs in global config to be unset

    By setting them to empty string
    MetRonnie committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    262126e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b02d74f View commit details
    Browse the repository at this point in the history
  8. Tidy

    MetRonnie committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    7e0ee50 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fa112a2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4581158 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2268f20 View commit details
    Browse the repository at this point in the history
  12. cylc clean: Fix tidying of empty run dir parents

    Add more unit tests
    MetRonnie committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    d7a9f82 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    634109b View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Configuration menu
    Copy the full SHA
    a2fcaea View commit details
    Browse the repository at this point in the history
  2. Update changelog

    MetRonnie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    6eb3500 View commit details
    Browse the repository at this point in the history
  3. Address code review

    MetRonnie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    82ec437 View commit details
    Browse the repository at this point in the history
  4. Targeted clean: Overhaul processing of glob results

    This filters out all redundant matches, i.e. matches that are subpaths
    of other matches (except for the std symlink dirs - we need to return
    these as we need to follow their targets).
    
    As was implemented in a previous commit, it still also filters out
    subpaths of symlinks as we don't want to follow symlinks (again except
    for the std symlink dirs).
    MetRonnie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    2300f4d View commit details
    Browse the repository at this point in the history
  5. Move glob_run_dir() to workflow_files

    Add unit tests
    MetRonnie committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    011e6e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Configuration menu
    Copy the full SHA
    3a44181 View commit details
    Browse the repository at this point in the history
  2. Fix small mistake

    MetRonnie committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    2dc0f0d View commit details
    Browse the repository at this point in the history
  3. Fix test failures

    MetRonnie committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    4f23670 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Remote clean: only re-run on different platform if SSH failed (255)

    Do not retry a failed clean on an install target using the next platform in the list if the remote clean command failed due to a non-SSH reason (if ret code != 255).
    MetRonnie committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    fadda2a View commit details
    Browse the repository at this point in the history