-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cylc clean 3: targeted clean #4237
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
988648f
Type annotations
MetRonnie 506bb38
cylc clean: add --remote-only option
MetRonnie eacdcce
Fix & refactor cylc clean unit tests
MetRonnie a037073
cylc clean: Implement targeted clean
MetRonnie 505b27b
Fix error when share/cycle sylink dir same as share
MetRonnie 262126e
Allow symlink dirs in global config to be unset
MetRonnie b02d74f
Fix #4133 - better error handling when rmtree fails
MetRonnie 7e0ee50
Tidy
MetRonnie fa112a2
cylc clean: Fix deletion of symlink dir targets in targeted clean
MetRonnie 4581158
cylc clean: overhaul targeted clean to make globs work
MetRonnie 2268f20
Refactor cylc clean test into fixture
MetRonnie d7a9f82
cylc clean: Fix tidying of empty run dir parents
MetRonnie 634109b
cylc clean: add help examples
MetRonnie a2fcaea
Remote clean: iterate over proc queue more elegantly
MetRonnie 6eb3500
Update changelog
MetRonnie 82ec437
Address code review
MetRonnie 2300f4d
Targeted clean: Overhaul processing of glob results
MetRonnie 011e6e0
Move glob_run_dir() to workflow_files
MetRonnie 3a44181
Merge branch 'master' into cylc-clean
MetRonnie 2dc0f0d
Fix small mistake
MetRonnie 4f23670
Fix test failures
MetRonnie fadda2a
Remote clean: only re-run on different platform if SSH failed (255)
MetRonnie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor comment more for future sake)
A pattern that is a bit nicer for Python interfaces and testing is to store
exc
as an attribute on theFileRemovalError
and handle the representation in the__str__
method.Will get around to refactoring the other errors one day when we have less to do 😆.