Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Tidy #302

Merged
merged 14 commits into from
Nov 5, 2019
Merged

Graph Tidy #302

merged 14 commits into from
Nov 5, 2019

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 5, 2019

These changes partially address #74

Mop up for the CytoscapeJS graph implementation.

Functionality should be unchanged (bas the two points in "Modify"):

  • Remove getNodes, getEdges, getJobs data wrappers.
    • Use data straight from the store, don't duplicate locally.
    • Don't define blank attributes by default, handle their absence gracefully later.
  • Tidy
    • Remove most inline-ifs.
    • Expand and simplify HTML.
    • Remove unused query parameters.
    • Remove unused attributes.
  • Modify
    • Remove suite name from graph (this will be done by the status bar)
    • Use the task name for the node text rather than the task id.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (refactor).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@oliver-sanders oliver-sanders added this to the 0.2 milestone Nov 5, 2019
@oliver-sanders oliver-sanders self-assigned this Nov 5, 2019
@hjoliver hjoliver merged commit 9b716e0 into cylc:master Nov 5, 2019
@oliver-sanders oliver-sanders deleted the graph branch November 6, 2019 12:44
@kinow kinow mentioned this pull request Jan 23, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants