-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up the Graph component (part #2) #383
Conversation
This comment has been minimized.
This comment has been minimized.
What do you mean by "the layout" here - the graph layout, or more general page layout of the UI? |
The graph layout I think. The styles used by Cytoscape. More specifically, the zoom is wrong, and the height of the graph area also appears to be wrong. But once these two are fixed, I think it should be ready for review. |
Technically the "graph layout" is the computed relative positions of all the graph nodes - the shape of the graph, sort of ... so maybe you mean the graph styling (and/or the viewport or whatever the term for that is) |
Oh, yup. Graph styling, sorry. I am just trying to remember where each style is used, and what CSS styles need changing. Should be done by today/tomorrow. |
…nt have its lifecycle matching the component lifecycle. Also, that the elements are accessed either by refs, or individually. With classes, when added to Lumino tabs, it would end up returning an array, and only one would be used... so the second graph widget would be blank, or confuse the other widget!
…h for toggling freeze flag
I think I got too excited, so didn't squash the commits so that I can revert some if requested. Will add some comments to the new code, but here are the main changes:
|
@@ -49,6 +49,7 @@ | |||
|
|||
<v-menu | |||
offset-y | |||
v-if="$route.name === 'workflow'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise "Add View" is available when accessing /#/tree/five
or /#/graph/five
— and it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, nice improvement.
-
Tested with 10 graph views on a small suite all displaying simultaneously.
- Memory usage good.
- System slightly laggy but nothing more than expected.
-
Tested with complex suite.
- Working as expected.
Thanks for the review @oliver-sanders ! |
@oliver-sanders sorry, pushed two more commits ☝️ The first is to make the widget wrapper to invoke the The second commit is to fix a console error I noticed could happen when the user closed the widget while the layout was "running" ( |
Interesting, I didn't see that. Code looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @kinow . With this and previous changes, the cytoscape graphview is now a decent POC for demo purposes, until we settle on the proper way forward...
These changes partially address #74 and #381, see also #302
Initial view of the Graph component when using this branch:
After dismissing the warning, and expanding the layout options:
Now left with a frozen graph, and dagre engine. While right has dismissed the warning, hierarchical layout, layout options hidden, and it is showing live data.
Tests above were done with Firefox 72.0.1 (64 bit) on Ubuntu LTS, using my home laptop.
@hjoliver it kinda works with 60.8. Will take another look tomorrow, but I suspect it's the Lumino widget and how it is handling updates and resizing.
For me, the
/#/graph/families2
view worked fine.But got the same issue reported by @hjoliver when using Lumino.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.