Skip to content

Commit

Permalink
test(launchpad): skip failure due to recaptcha on windows, enable mor…
Browse files Browse the repository at this point in the history
…e windows jobs (#21620)

Co-authored-by: Tyler Biethman <tbiethman@users.noreply.github.com>
  • Loading branch information
flotwig and tbiethman authored May 24, 2022
1 parent 015e948 commit ae078c7
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 14 deletions.
26 changes: 13 additions & 13 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,16 @@ macWorkflowFilters: &mac-workflow-filters
pattern: "-release$"
value: << pipeline.git.branch >>

windowsWorkflowFilters: &windows-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ '10.0-release', << pipeline.git.branch >> ]
- equal: [ 'tbiethman/UNIFY-1787-spec-names-with-ext', << pipeline.git.branch >> ]
- matches:
pattern: "-release$"
value: << pipeline.git.branch >>
- matches:
pattern: "win*"
value: << pipeline.git.branch >>
# windows is slow in CI, so we only run a certain set of tests on each commit
# add your branch to this list to run the full Windows build on your PR
fullWindowsWorkflowFilters: &full-windows-workflow-filters
filters:
branches:
only:
- develop
- '10.0-release'
- '*-release'
- 'win*'

executors:
# the Docker image with Cypress dependencies and Chrome browser
Expand Down Expand Up @@ -2572,19 +2570,22 @@ windows-workflow: &windows-workflow
- windows-build

- lint:
<<: *full-windows-workflow-filters
name: windows-lint
executor: windows
requires:
- windows-build

- unit-tests:
<<: *full-windows-workflow-filters
name: windows-unit-tests
executor: windows
resource_class: windows.medium
requires:
- windows-build

- create-build-artifacts:
<<: *full-windows-workflow-filters
name: windows-create-build-artifacts
executor: windows
resource_class: windows.medium
Expand All @@ -2609,4 +2610,3 @@ workflows:
<<: *mac-workflow-filters
windows:
<<: *windows-workflow
<<: *windows-workflow-filters
6 changes: 5 additions & 1 deletion packages/launchpad/cypress/e2e/migration.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,11 @@ describe('Opening unmigrated project', () => {
// the expected iframe code is being returned and that there is vimeo-related network traffic
cy.get('[data-cy="video-container"] iframe[src*=vimeo]').should('be.visible')
cy.wait('@iframeDocRequest')
cy.wait('@vimeoCdnRequest')

// For an unknown reason, recaptcha blocks us from loading Vimeo on CircleCI Windows only
// So only wait on the Vimeo CDN request on Linux/Darwin.
if (Cypress.platform !== 'win32') cy.wait('@vimeoCdnRequest')

cy.percySnapshot()
})

Expand Down

3 comments on commit ae078c7

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ae078c7 May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.0.0/linux-x64/10.0-release-ae078c74959ddd542ba6ad706613bfec1f07f761/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ae078c7 May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.0.0/darwin-x64/10.0-release-ae078c74959ddd542ba6ad706613bfec1f07f761/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ae078c7 May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.0.0/win32-x64/10.0-release-ae078c74959ddd542ba6ad706613bfec1f07f761/cypress.tgz

Please sign in to comment.