Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs #21620

Merged
merged 11 commits into from
May 24, 2022
Merged

test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs #21620

merged 11 commits into from
May 24, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented May 24, 2022 •
edited
Loading

User facing changelog

N/A

Additional details

  • Was only able to reproduce in CircleCI, not on a regular Windows Server VM.
  • Looking at the requests, it seems like ReCAPTCHA requests are the last things to go out, and then a vimeocdn request is never sent.
  • My assumption is that ReCAPTCHA is preventing us from loading Vimeo, so we can skip this on Windows.
    • I'm not sure what else could be done. Maybe we can hire someone to solve CAPTCHAs for our CI pipeline as an alternative? 😄
  • Manually tested Windows launchpad and the video does work.
  • Enables Windows app and launchpad tests on all PRs now that they pass.

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 24, 2022

Thanks for taking the time to open a PR!

@flotwig flotwig force-pushed the unify-1813-windows-video-test branch from ade0181 to 929c316 Compare May 24, 2022 21:01
@cypress
Copy link

cypress bot commented May 24, 2022 •
edited
Loading


Test summary

37529 • 0 • 454 • 0 • Flakiness 7

Run details
Project cypress
Status Passed
Commit 916db8a
Started May 24, 2022 9:54 PM
Ended May 24, 2022 10:14 PM
Duration 20:18 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

commands/actions/click.cy.js 1 Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
commands/net_stubbing.cy.ts 1 Flakiness
1 network stubbing > intercepting response > can delay a proxy response using res.setDelay
next.cy.ts 2 Flakiness
1 Working with next-12 > should detect new spec
2 Working with next-12.1.6 > should detect new spec
e2e/origin/commands/assertions.cy.ts 1 Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review May 24, 2022 21:39
@flotwig flotwig changed the title test(launchpad): skip cy.wait(vimeoCdnRequest) on windows test(launchpad): skip cy.wait(vimeoCdnRequest) on windows, enable more windows jobs May 24, 2022
@flotwig flotwig changed the title test(launchpad): skip cy.wait(vimeoCdnRequest) on windows, enable more windows jobs test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs May 24, 2022
@tbiethman tbiethman self-requested a review May 24, 2022 21:43
@flotwig @tbiethman
Update packages/launchpad/cypress/e2e/migration.cy.ts
916db8a 
Co-authored-by: Tyler Biethman <tbiethman@users.noreply.github.com>
@flotwig flotwig merged commit ae078c7 into 10.0-release May 24, 2022
@flotwig flotwig deleted the unify-1813-windows-video-test branch May 24, 2022 22:58
tgriesser added a commit that referenced this pull request May 25, 2022
@tgriesser
Merge branch 'develop' into tgriesser/feat/UNIFY-1774-auto-source-web…
50e6d4c 
…pack

* develop:
  test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs (#21620)
  docs: add "Steps to test" to PR template (#21606)
  feat: (origin) handle waiting for aliased intercepts (#21579)
  fix: handle git watch error (#21600)
  fix: Successfully create new specs files that do not have a known extension (#21593)
  chore: release 9.7.0
  fix: do not allow experimentalSessionAndOrigin to be available in CT … (#21588)
  chore: sort the frameworks select dropdown in a more logical way (#21553)
  Trigger Build
  fix: disable ct testing when run via binary (#21540)
  chore: Update Chrome (beta) to 102.0.5005.61 (#21556)
  chore: release @cypress/react-v5.12.5
  fix: add support for Next.js v12.1.6 (#21516)
  chore: release @cypress/schematic-v1.7.0
  feat(cypress/schematic): add headed option and other fixes (#21415)
  chore: release @cypress/vite-dev-server-v2.2.3
  fix: handle specs with white space in vite-dev-server (#21386)
  Empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbiethman tbiethman tbiethman approved these changes

@mschile mschile mschile approved these changes

@marktnoonan marktnoonan marktnoonan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flotwig @tbiethman @mschile @marktnoonan