Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs #21620

Merged
merged 11 commits into from
May 24, 2022
26 changes: 13 additions & 13 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,16 @@ macWorkflowFilters: &mac-workflow-filters
pattern: "-release$"
value: << pipeline.git.branch >>

windowsWorkflowFilters: &windows-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ '10.0-release', << pipeline.git.branch >> ]
- equal: [ 'tbiethman/UNIFY-1787-spec-names-with-ext', << pipeline.git.branch >> ]
- matches:
pattern: "-release$"
value: << pipeline.git.branch >>
- matches:
pattern: "win*"
value: << pipeline.git.branch >>
# windows is slow in CI, so we only run a certain set of tests on each commit
# add your branch to this list to run the full Windows build on your PR
fullWindowsWorkflowFilters: &full-windows-workflow-filters
filters:
branches:
only:
- develop
- '10.0-release'
- '*-release'
- 'win*'

executors:
# the Docker image with Cypress dependencies and Chrome browser
Expand Down Expand Up @@ -2572,19 +2570,22 @@ windows-workflow: &windows-workflow
- windows-build

- lint:
<<: *full-windows-workflow-filters
name: windows-lint
executor: windows
requires:
- windows-build

- unit-tests:
<<: *full-windows-workflow-filters
name: windows-unit-tests
executor: windows
resource_class: windows.medium
requires:
- windows-build

- create-build-artifacts:
<<: *full-windows-workflow-filters
name: windows-create-build-artifacts
executor: windows
resource_class: windows.medium
Expand All @@ -2609,4 +2610,3 @@ workflows:
<<: *mac-workflow-filters
windows:
<<: *windows-workflow
<<: *windows-workflow-filters
6 changes: 5 additions & 1 deletion packages/launchpad/cypress/e2e/migration.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,11 @@ describe('Opening unmigrated project', () => {
// the expected iframe code is being returned and that there is vimeo-related network traffic
cy.get('[data-cy="video-container"] iframe[src*=vimeo]').should('be.visible')
cy.wait('@iframeDocRequest')
cy.wait('@vimeoCdnRequest')

// For an unknown reason, recaptcha blocks us from loading Vimeo on CircleCI Windows only
// So only wait on the Vimeo CDN request on Linux/Darwin.
if (Cypress.platform !== 'win32') cy.wait('@vimeoCdnRequest')

cy.percySnapshot()
})

Expand Down