Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for Next.js v12.1.6 #21516

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented May 16, 2022

User facing changelog

Add support for Next v12.1.6

Additional details

The API for getNextJsBaseWebpackConfig has changed in version 12.1.6 which was causing the resolved webpack config to not be the client webpack configuration. Small tweak passing in both options allows support for the new change and backwards compatibility.

How has the user experience changed?

CT testing works with latest version on Next

Testing

I have a clone of this PR targeting 10.0-release that has e2e tests covering this new version of Next.
#21515

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@ZachJW34 ZachJW34 requested a review from a team as a code owner May 16, 2022 16:59
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 16, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented May 16, 2022



Test summary

9330 1 112 1Flakiness 0


Run details

Project cypress
Status Failed
Commit 79140c6
Started May 17, 2022 2:47 PM
Ended May 17, 2022 3:05 PM
Duration 17:47 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


Failures

cypress/integration/commands/files_spec.js Failed
1 ... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 changed the title Empty commit fix: add support for Next.js v12.1.6 May 16, 2022
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - not sure how you figured this out, but 💯

Glad we have a test in the clone PR, too.

@ZachJW34
Copy link
Contributor Author

ZachJW34 commented May 17, 2022

@lmiller1990 I did a full reset of a local Next repo to 12.1.5 and traced the changes starting at getNextJsBaseWebpackConfig. They are working on an Edge compiler for "upcoming middleware work".

@ZachJW34 ZachJW34 merged commit 72ed33c into master May 17, 2022
@ZachJW34 ZachJW34 deleted the zachw/next-12.1.6-support-master branch May 17, 2022 20:27
admah pushed a commit that referenced this pull request May 20, 2022
tgriesser added a commit that referenced this pull request May 25, 2022
…pack

* develop:
  test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs (#21620)
  docs: add "Steps to test" to PR template (#21606)
  feat: (origin) handle waiting for aliased intercepts (#21579)
  fix: handle git watch error (#21600)
  fix: Successfully create new specs files that do not have a known extension (#21593)
  chore: release 9.7.0
  fix: do not allow experimentalSessionAndOrigin to be available in CT … (#21588)
  chore: sort the frameworks select dropdown in a more logical way (#21553)
  Trigger Build
  fix: disable ct testing when run via binary (#21540)
  chore: Update Chrome (beta) to 102.0.5005.61 (#21556)
  chore: release @cypress/react-v5.12.5
  fix: add support for Next.js v12.1.6 (#21516)
  chore: release @cypress/schematic-v1.7.0
  feat(cypress/schematic): add headed option and other fixes (#21415)
  chore: release @cypress/vite-dev-server-v2.2.3
  fix: handle specs with white space in vite-dev-server (#21386)
  Empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants