Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next 12.1.6 support and add tests #21515

Merged
merged 4 commits into from
May 18, 2022

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented May 16, 2022

User facing changelog

n/a

Additional details

Adding tests for Next.js v12.1.6 since the testing support for component projects is much greater on 10.0-release. I've created a PR targeting master that has only the src changes so as to release this fix faster.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@ZachJW34 ZachJW34 requested review from a team as code owners May 16, 2022 16:58
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 16, 2022

Thanks for taking the time to open a PR!

@ZachJW34 ZachJW34 requested review from jennifer-shehane and removed request for a team May 16, 2022 16:58
@cypress
Copy link

cypress bot commented May 16, 2022



Test summary

37428 0 454 0Flakiness 5


Run details

Project cypress
Status Passed
Commit ec66046
Started May 17, 2022 10:16 PM
Ended May 17, 2022 10:35 PM
Duration 18:52 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing.cy.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single response using "alias"
commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 requested review from lmiller1990 and BlueWinds and removed request for jennifer-shehane May 16, 2022 18:03
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why/how does this fix the problem? Do we know?

Also, CI seems to be failing - not sure if real problem or just needs a re-run.

Edit: you explained here: #21516. Seems fine. Not entirely sure how you figured this out or why this was changed in a patch release for Next.js.

@ZachJW34
Copy link
Contributor Author

Going to merge when green, the corresponding PR to master has been merged and released.

@lmiller1990 lmiller1990 merged commit ada7179 into 10.0-release May 18, 2022
@lmiller1990 lmiller1990 deleted the zachw/next-12.1.6-support branch May 18, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants