chore: sort the frameworks select dropdown in a more logical way #21553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
lmiller1990
changed the title
lmiller1990
requested review from
marktnoonan,
elevatebart and
emilyrohrbough
and removed request for
tgriesser
elevatebart
approved these changes
May 19, 2022
|
@lmiller1990 Can you create a corresponding Jira issue to track this work? I would prefer just alphabetical as an aside. If this screenshot reflects the current state, it still looks illogical to me. |
|
@jennifer-shehane done, also just changed to alphabetical order, much more simple + added tests. |
ZachJW34
reviewed
May 20, 2022
|
@lmiller1990 which screenshot is the source of truth? Looks like neither screenshot is in alphabetical order, so I feel like i'm missing something. |
lmiller1990
force-pushed
the
lmiller1990/improve-sorting-in-wizard
branch
from
24a975c
to
ff425a6
Compare
|
@emilyrohrbough oops, I've updated the screenshot. thanks! |
emilyrohrbough
approved these changes
May 23, 2022
ZachJW34
approved these changes
May 23, 2022
tgriesser
added a commit
that referenced
this pull request
May 25, 2022
…pack * develop: test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs (#21620) docs: add "Steps to test" to PR template (#21606) feat: (origin) handle waiting for aliased intercepts (#21579) fix: handle git watch error (#21600) fix: Successfully create new specs files that do not have a known extension (#21593) chore: release 9.7.0 fix: do not allow experimentalSessionAndOrigin to be available in CT … (#21588) chore: sort the frameworks select dropdown in a more logical way (#21553) Trigger Build fix: disable ct testing when run via binary (#21540) chore: Update Chrome (beta) to 102.0.5005.61 (#21556) chore: release @cypress/react-v5.12.5 fix: add support for Next.js v12.1.6 (#21516) chore: release @cypress/schematic-v1.7.0 feat(cypress/schematic): add headed option and other fixes (#21415) chore: release @cypress/vite-dev-server-v2.2.3 fix: handle specs with white space in vite-dev-server (#21386) Empty commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Sort the frameworks in a more structured manner on the select framework screen.
Additional details
Put in alphabetical order.
Open to other ways to order the list, just threw this together since the current list is just in an arbitrary order.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?