Skip to content

Commit

Permalink
fix: Proxy-Authorization: Basic (#22471)
Browse files Browse the repository at this point in the history
Co-authored-by: buloheart <buloheart@gmail.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
  • Loading branch information
5 people authored Jun 29, 2022
1 parent 9658e9f commit b1a51f9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/network/lib/agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function buildConnectReqHead (hostname: string, port: string, proxy: url.
connectReq.push(`Host: ${hostname}:${port}`)

if (proxy.auth) {
connectReq.push(`Proxy-Authorization: basic ${Buffer.from(proxy.auth).toString('base64')}`)
connectReq.push(`Proxy-Authorization: Basic ${Buffer.from(proxy.auth).toString('base64')}`)
}

return connectReq.join(CRLF) + _.repeat(CRLF, 2)
Expand Down
2 changes: 1 addition & 1 deletion packages/network/test/unit/agent_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ describe('lib/agent', function () {
expect(head).to.eq([
'CONNECT foo.bar:1234 HTTP/1.1',
'Host: foo.bar:1234',
'Proxy-Authorization: basic YmF6OnF1dXg=',
'Proxy-Authorization: Basic YmF6OnF1dXg=',
'', '',
].join('\r\n'))
})
Expand Down

5 comments on commit b1a51f9

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b1a51f9 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/linux-x64/develop-b1a51f9b49ef23f713fb9ba050c540972b1f140c/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b1a51f9 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/linux-arm64/develop-b1a51f9b49ef23f713fb9ba050c540972b1f140c/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b1a51f9 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/darwin-arm64/develop-b1a51f9b49ef23f713fb9ba050c540972b1f140c/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b1a51f9 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/darwin-x64/develop-b1a51f9b49ef23f713fb9ba050c540972b1f140c/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b1a51f9 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/win32-x64/develop-b1a51f9b49ef23f713fb9ba050c540972b1f140c/cypress.tgz

Please sign in to comment.