Skip to content

Commit

Permalink
fix: Display full spec file extension in popovers (#23350)
Browse files Browse the repository at this point in the history
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
  • Loading branch information
mike-plummer and emilyrohrbough authored Aug 16, 2022
1 parent e703ab4 commit d676448
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/specs_list_flaky.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ describe('App: Spec List - Flaky Indicator', () => {
cy.contains('[data-cy="spec-item"]', '123.spec.js').find('.v-popper').trigger('mouseenter')

cy.findByTestId('flaky-spec-summary').within(() => {
cy.contains('123.js')
cy.contains('123.spec.js')
cy.contains('Low')
cy.contains('4% flaky rate')
cy.contains('2 flaky runs / 50 total')
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/specs/SpecsList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
<RunStatusDots
v-if="row.data.isLeaf && row.data.data && (row.data.data.cloudSpec?.data || row.data.data.cloudSpec?.fetchingStatus !== 'FETCHING')"
:gql="row.data.data.cloudSpec ?? null"
:spec-file-extension="row.data.data.fileExtension"
:spec-file-extension="row.data.data.specFileExtension"
:spec-file-name="row.data.data.fileName"
/>
<div
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/specs/flaky-badge/FlakyInformation.cy.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe('<FlakyInformation />', () => {
__typename: 'Spec',
id: '2',
fileName: 'abc',
fileExtension: 'cy.tsx',
specFileExtension: 'cy.tsx',
relative: 'test/abc.cy.tsx',
}
const cloudSpec: FlakyInformationCloudSpecFragment = {
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/specs/flaky-badge/FlakyInformation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
:from-branch="props.projectGql?.branch || ''"
:spec-path="props.specGql.relative"
:spec-name="props.specGql?.fileName ?? ''"
:spec-extension="props.specGql?.fileExtension ?? ''"
:spec-extension="props.specGql?.specFileExtension ?? ''"
/>
</ExternalLink>
</template>
Expand Down Expand Up @@ -56,7 +56,7 @@ fragment FlakyInformationSpec on Spec {
id
relative
fileName
fileExtension
specFileExtension
}
`
Expand Down

4 comments on commit d676448

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on d676448 Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.6.0/linux-x64/develop-d6764487e14ca19a8186cba135c029fbaf043854/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on d676448 Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.6.0/linux-arm64/develop-d6764487e14ca19a8186cba135c029fbaf043854/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on d676448 Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.6.0/darwin-x64/develop-d6764487e14ca19a8186cba135c029fbaf043854/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on d676448 Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.6.0/win32-x64/develop-d6764487e14ca19a8186cba135c029fbaf043854/cypress.tgz

Please sign in to comment.