Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display full spec file extension in popovers #23350

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

mike-plummer
Copy link
Contributor

User facing changelog

  • Fix issue where popovers would not display full filename of spec files

Additional details

Steps to test

  1. Open this example project e2e project in the app - this project has existing cloud recording data including flaky runs in staging
  2. Ensure you are logged in to the dashboard - latest run and flaky data should automatically load
  3. Mouse over the Latest Runs row items, validate that the full spec filename is displayed in the popover
  4. Find a flaky test, mouse over the Flaky indicator and validate the full spec filename is displayed in the popover

How has the user experience changed?

Before - note the missing ".cy"
before-latest-runs

before-flaky

After
after-latest-runs

after-flaky

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 15, 2022



Test summary

37828 0 615 0Flakiness 8


Run details

Project cypress
Status Passed
Commit f6b4af1
Started Aug 16, 2022 3:48 PM
Ended Aug 16, 2022 4:10 PM
Duration 22:02 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay with deprecated delayMs param
2 network stubbing > intercepting request > can delay with deprecated delayMs param
3 network stubbing > intercepting request > can delay with deprecated delayMs param
4 network stubbing > intercepting request > can delay with deprecated delayMs param
5 network stubbing > intercepting request > can delay with deprecated delayMs param
This comment includes only the first 5 flaky tests. See all 8 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mike-plummer mike-plummer marked this pull request as ready for review August 16, 2022 13:52
Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@astone123 astone123 self-requested a review August 16, 2022 15:08
Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@mike-plummer mike-plummer merged commit d676448 into develop Aug 16, 2022
@mike-plummer mike-plummer deleted the mikep/23064-spec-name-display branch August 16, 2022 16:30
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 16, 2022

Released in 10.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specs Explorer tooltips do not use full spec name
4 participants