Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add more plugin events to mirror driver events #2283

Closed
chrisbreiding opened this issue Aug 6, 2018 · 4 comments
Closed

Proposal: Add more plugin events to mirror driver events #2283

chrisbreiding opened this issue Aug 6, 2018 · 4 comments
Assignees
@chrisbreiding
Labels
pkg/server This is due to an issue in the packages/server directory type: breaking change Requires a new major release version type: feature New feature that does not currently exist
Milestone
Sprint 15

Comments

@chrisbreiding
Copy link
Contributor

chrisbreiding commented Aug 6, 2018 •
edited
Loading

Add the following plugin events that mirror the driver events that occur in the browser.

  • test:before:run
  • test:after:run

Related: #2177
@chrisbreiding chrisbreiding added the type: feature New feature that does not currently exist label Aug 6, 2018
@chrisbreiding chrisbreiding self-assigned this Aug 6, 2018
@chrisbreiding chrisbreiding added the pkg/server This is due to an issue in the packages/server directory label Aug 6, 2018
@jennifer-shehane jennifer-shehane added the stage: proposal 💡 No work has been done of this issue label Aug 6, 2018
@chrisbreiding chrisbreiding mentioned this issue Aug 8, 2018
Merged
@chrisbreiding chrisbreiding added stage: in progress type: breaking change Requires a new major release version and removed stage: proposal 💡 No work has been done of this issue labels Aug 30, 2018
@chrisbreiding chrisbreiding modified the milestones: Sprint 0.5, Sprint 1 Sep 4, 2018
@brian-mann brian-mann modified the milestones: Sprint 1, Sprint 2 Sep 10, 2018
@jennifer-shehane jennifer-shehane modified the milestones: Sprint 2, Sprint 3 Sep 17, 2018
@chrisbreiding chrisbreiding modified the milestones: Sprint 3, Sprint 4 Sep 24, 2018
@chrisbreiding chrisbreiding mentioned this issue Nov 26, 2018
Closed
31 tasks
@chrisbreiding chrisbreiding modified the milestones: Sprint 13, Sprint 14 Dec 3, 2018
chrisbreiding added a commit that referenced this issue Dec 4, 2018
@chrisbreiding
Add plugin events that mirror driver events (#2309)
aac89a1 
* Closes #2283 

Related:

* Docs: cypress-io/cypress-documentation#967
* cypress-on: https://github.com/cypress-io/cypress-on/pull/96
@chrisbreiding chrisbreiding modified the milestones: Sprint 14, Sprint 15 Dec 10, 2018
@badeball
Copy link
Contributor

Were these events removed at some point? Listening to test:after:run from a plugin is not allowed per v12.14.0.

@badeball badeball mentioned this issue Jun 20, 2023
Closed
3 tasks
@mike-plummer
Copy link
Contributor

Hi @badeball - this was never actually released. This went into a feature branch that never ended up merging down

@badeball
Copy link
Contributor

That’s a bummer. Any chance that this could be reconsidered?

@mike-plummer
Copy link
Contributor

@badeball Since is from waaay back so I doubt it could be cleanly picked back up as-is. If there are specific events you're wanting exposed you're welcome to submit a feature request so we can review - would be helpful to know the use case, what event(s) are needed, etc

@badeball badeball mentioned this issue Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbreiding chrisbreiding

Labels
pkg/server This is due to an issue in the packages/server directory type: breaking change Requires a new major release version type: feature New feature that does not currently exist
Projects
None yet
Milestone
Sprint 15
Development

No branches or pull requests
5 participants
@badeball @chrisbreiding @brian-mann @jennifer-shehane @mike-plummer