Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin events that mirror driver events #2309

Merged
merged 39 commits into from
Dec 4, 2018
Merged

Add plugin events that mirror driver events #2309

merged 39 commits into from
Dec 4, 2018

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Aug 8, 2018 •
edited
Loading

@chrisbreiding
add plugin events that mirror various driver events
c51dba8 
implemented the following:
- test:before:run
- command:enqueued
- command:start
- command:retry
- command:end
- fail
- test:after:run
@chrisbreiding
improve serialization
8cbc3bc
@chrisbreiding
be more conservative with serializing
1976bc1 
commands can have anything as args and complex objects cause socket serialization to blow call stack, so just don’t include them to be safe
@chrisbreiding
fix tests
8c72c4a
@chrisbreiding
fix tests
bb79625
@chrisbreiding chrisbreiding self-assigned this Aug 8, 2018
@chrisbreiding chrisbreiding added the type: breaking change Requires a new major release version label Aug 30, 2018
@chrisbreiding chrisbreiding mentioned this pull request Aug 31, 2018
Closed
@chrisbreiding chrisbreiding modified the milestone: Sprint 0.5 Sep 4, 2018
@chrisbreiding chrisbreiding mentioned this pull request Nov 26, 2018
Closed
31 tasks
@chrisbreiding chrisbreiding changed the base branch from develop to v4.0 December 4, 2018 15:00
@chrisbreiding chrisbreiding merged commit aac89a1 into v4.0 Dec 4, 2018
@chrisbreiding chrisbreiding deleted the issue-2283-driver-to-plugin-events branch December 4, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane requested changes

@brian-mann brian-mann Awaiting requested review from brian-mann

Assignees

@chrisbreiding chrisbreiding

Labels
type: breaking change Requires a new major release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisbreiding @jennifer-shehane @brian-mann