Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unintentionally exposed private properties from Module API #8076

Closed
kuceb opened this issue Jul 23, 2020 · 2 comments
Closed

Remove unintentionally exposed private properties from Module API #8076

kuceb opened this issue Jul 23, 2020 · 2 comments
Assignees
@kuceb
Labels
type: breaking change Requires a new major release version

Comments

@kuceb
Copy link
Contributor

kuceb commented Jul 23, 2020

we have several properties on Module API test run results that are not useful to users:
timings
testId
failedFromHookId

reasons for removing:

  • these properties were not created for use by end users
  • unintentionally couples public Module API to dashboard API
  • when we make changes to dashboard API, we don't want to affect public API
@kuceb kuceb self-assigned this Jul 23, 2020
@flotwig flotwig mentioned this issue Jul 23, 2020
Merged
21 tasks
@cypress-io cypress-io deleted a comment from bahmutov Jul 23, 2020
@jennifer-shehane jennifer-shehane added type: breaking change Requires a new major release version stage: ready for work The issue is reproducible and in scope labels Jul 24, 2020
@kuceb kuceb mentioned this issue Jul 31, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Jul 31, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: pending release and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Aug 11, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 11, 2020

The code for this is done in cypress-io/cypress#8148, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
type: breaking change Requires a new major release version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennifer-shehane @kuceb