Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove private properties, move screenshots in module API results #8148

Merged
merged 404 commits into from
Aug 11, 2020

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Jul 31, 2020

User facing changelog

  • remove unintentionally exposed properties on Module API
  • Module API results now list screenshots nested under each test attempt object instead of on the higher level run object

Additional details

  • move e2e tests around timing from 5_spec_isolation to 7_record_spec since timings are no longer on module API result json

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

kuceb and others added 30 commits April 14, 2020 23:27
- This was the older styling before error improvements and is no longer
necessary.
@kuceb kuceb changed the title remove private properties from module API results fix: remove private properties from module API results Jul 31, 2020
@kuceb kuceb changed the title fix: remove private properties from module API results fix: remove private properties, move screenshots in module API results Jul 31, 2020
@kuceb kuceb changed the base branch from test-retries to v5.0-release August 4, 2020 13:33

const firstInstancePut = requests[2]
console.log(stdout)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants