fix(server): Fix 5.0 spec duration always reporting as 0ms #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e spec duration always > 0ms in e2e tests
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Looks like we do have a number of tests that take 0ms... |
|
the tests are too fast ... |
|
Looks like it happens when the tests don't even run because of a syntax error or plugins file error. |
|
@bkucera is this a wrong return from module API? maybe the module API test could just confirm it? |
|
I requested the review too early, I'm fixing these now |
chrisbreiding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exists only in develop
fixes bug introduced by #8148 causing spec durations to be printed as
0msin the final spec results.fix #8309 (unreleased)
before:
after:
