feat: v5.0 release #7753
Merged
feat: v5.0 release #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jennifer-shehane
added
the
type: breaking change
14 tasks
* chore(deps): electron@9.0.5 BREAKING CHANGE: libgbm is a requirement * update node, xcode, docker images * lockfile * chore(types): tsify lib/gui/windows and spec * fix Electron extension loading global extension loading was deprecated in 9, now has to be per-session * make windows fns stubbable * update electron_spec * tsify issue_173_spec * use upstream foxdriver to fix FF >= 75 see benmalka/foxdriver#7 * update test * for now, install libgbm-dev at ci time see cypress-io/cypress-docker-images#332 * fix open mode * remove devtools-ext dir
* feat: make cookies have sameSite key by default BREAKING CHANGE: modifies the shape of Cookie objects * update tests * add deprecation notice Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* Require Node 10+ for cli engine * update chalk to latest (requires Node 10+) * Update execa to latest * Update cli-table3 to latest (required Node 10+) * Update log-symbols (requires Node 10+) * Update tmp dep (requires Node >=8.17.0) * Update fs-extra dep (requires Node 10) * Update mock-fs to 4.12.0 * increase circle base image to node 10 * fix flaky firefox test * make job names consistent * reconfigure percy parallelism, finalize percy after running visual jobs, remove separate desktop-gui-visual-tests job * rename job correctly Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* Rename non-user facing instances of whitelist * Rename server option 'whitelist' to 'ignore' * Update use of whitelist with server to throw instead of warn * Rename Cypress.Cookies.defaults 'whitelist' option to 'preserve' * fix circle yml parameter parsing consistent * compose cloning an external repo and switching to the NEXT_DEV_VERSION branch consistently * add cypress org to repo parameter * cd into the right dir before switching branches * one line git checkout * simplify passing repo * cd into the right dir * clone into the right dir * oh my cd 101 * replace kitchen sink strings for 5.0.0 Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Co-authored-by: Oliver Joseph Ash <oliverjash@gmail.com>
# Conflicts: # cli/package.json # packages/server/test/support/fixtures/projects/e2e/cypress/integration/r equest_spec.coffee
Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Latest version for 5.0.0 release
* make tests preprocessor agnostic * update eslintignore * put back deps needed for e2e test * remove obselete snapshot it was replaced by 1_typescript_support_spec.ts.js * switch from browserify to webpack preprocessor * cmon github * fix/update tests * bump preprocessor and update snapshots * update snapshots * bump preprocessor to gain json support * fix e2e tests with webpack-originated errors * bump preprocessor version, fix node globals * update snapshot * remove support for ? in file path * bump preprocessor version * bump preprocessor again * bump preprocessor * bump preprocessor * update snapshots * bump preprocessor version * bump preprocessor, quiet the paths plugin * add test verifying tsconfig paths work * bump batteries-included preprocessor and install latest webpack preprocessor beside it * update snapshots * put back snapshot * update snapshot * update snapshot Co-authored-by: Brian Mann <brian.mann86@gmail.com>
…sor (#8143) * make tests preprocessor agnostic * update eslintignore * put back deps needed for e2e test * remove obselete snapshot it was replaced by 1_typescript_support_spec.ts.js * switch from browserify to webpack preprocessor * cmon github * fix/update tests * bump preprocessor and update snapshots * update snapshots * bump preprocessor to gain json support * fix e2e tests with webpack-originated errors * bump preprocessor version, fix node globals * update snapshot * remove support for ? in file path * bump preprocessor version * bump preprocessor again * bump preprocessor * bump preprocessor * update snapshots * bump preprocessor version * bump preprocessor, quiet the paths plugin * add test verifying tsconfig paths work * refactor registering ts-node * separate spec/support file typescript tests from plugins file typescript tests * fix unit tests * fix: Remove esModuleInterop default from ts-node (#7808) * Remove esModuleInterop from ts-node. * Add e2e test. * Fix test. Change test name. Add comment. * Fix test snapshot name. * update snapshotting Co-authored-by: Chris Breiding <chrisbreiding@gmail.com> * clean up e2e project * bump preprocessor to 1.3.2, which removes esModuleInterop default value * improve esmoduleinterop e2e tests * change spec file * bump batteries-included preprocessor and install latest webpack preprocessor beside it * update snapshots * put back snapshot * update snapshot * update snapshot Co-authored-by: Kukhyeon Heo <sainthkh@naver.com> Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* add retries e2e test * restore runner/test/eslintrc * use mocha pass event, move runner.spec to runner package * fix .eslintignore * remove npmInstall logic in helper/e2e script, force custom reporters to use our mocha * temp 04/09/20 [skip ci] * add retries output to server/reporter, fix mocha pass event order, cleanup * e2e tests - dont run electron tests in other browsers * Update readme to reflect how to start server for cypress tests * fix after merge * fix .coffee -> .js after merge * fix attempt.tsx * fix runnable titles emitted to terminal reporters * fix more tests: update snapshots, fix 7_record_spec, 8_reporters_spec * remove styling for 'attempt-error-region' so it's not indented - This was the older styling before error improvements and is no longer necessary. * try 2: fix rerun before/after hooks * fix runner with only, runner snapshots, lint fixes * temp 04/29/20 [skip ci] * backport changes from test-retries * change logic to rerun before hooks after top navigation * fix windowSize for browser e2e test * fix windowSize for xvfb chrome in e2e test * ok fine, just disable screenshots * fix after merge: decaffed navigation.js * update server/unit test snapshots * fix after merge: decaffed aliases.js * fix usage of cypress --parallel flag in circle.yml * fix circle.yml integration-tests jobs * fix decaf related typo * fix circle.yml separate command for runner-integration-tests * update runner/integration tests + snapshot after error improvements * fix runner/integration snapshots for chrome/ff stacktrace differences * rerun ci * fix passing --parallel to runner-integration tests * perf: faster lookup for hooks without runnables * fix afterAll hook switch logic * simplify mocha prototype patches * fix decaf utils.coffee after merge * backport to before/after fix * backport to before/after fix 2 * cleanup from decaf, fix ui/package.json * update helpers, simplify runner.spec * fix lint-types errors, flaky spec * fix noExit passed to e2e test inline options * cleanup snapshot utility - refactor to use util file * remove before/after changes * make cy obj a class instance * cleanup/unmerge before/after fixes PR... * more cleanup * add comment * fix runner.spec * cleanup snapshot utility more, cleanup reporter.spec * fix after merge * minor rename variable * fix after merge: decaffed files * fix specName in reporterHeader, spec_helper require * replace reporter specPath usages with spec object from config * cleanup, fix specs, fix types tests * fix config spec paths in isolated runner, fix snapshot plugin button * combine runner.spec.js and runner_spec.js * fix incorrect merge * minor minor cleanup * rename driver/test/cypress to driver/test * use yarn workspace over lerna for individual package commands * add error message to driver start * remove usage of wait-on * update <reference types/>, import string * fix driver/readme * fix readmes after regex replace * revert wait-on changes * Revert "revert wait-on changes" This reverts commit 6de684c. * update yarn.lock * fix broken path in spec * fix broken paths in specs with @packages/driver * move runner/test/cypress into runner/cypress * start server in pluginsFile in runner/cypress tests * fix more broken spec paths * fix broken paths after runner/cypress folder move * move type definition loading for driver/cypress into dedicated file * move internal-types to "types" folder, fix driver/index.d.ts * fix type-check in packages/runner. not exactly sure why * fix runner type-check by excluding test folder in tsconfig * bump timeout on e2e/8_error_ui_spec * update snapshot utility, rename tests in runner/runner.spec, fix README yarn commands * delete old spec * fix snapshot naming, remove redundant test in reporter_spec * fix file renames after merge * rename runner/ snapshot * update server/unit/reporter_spec snapshot * update runner/runner_spec snapshot * rename runner snapshot file * address feedback: move server reporter snapshot specs out * address feedback: add comment about exposing globals * fix test-retries after merging isolated-runner * fix runner/test helper, update snapshot * address feedback: split out runner/retries spec, move reporter/ui tests to runner/ui spec (mostly done), various cleanup * fix scrolling, attempt opening, update snapshots * fix e2e support file * fix 5_spec_isolation * fix mislabeling attempt screenshots * only add test results prevAttempts if exists * fix reporter/unit tests, server/unit tests * remove dead code, fix test isOpen * update snapshots for retries.mochaEvents, fix snapshot error in state hydration test, remove dead snapshots * new moduleAPI schema using attempts array, fix wrapping errors from hook retries, update snapshots * add displayError, null out fields in moduleAPI schema * change default retries to {runMode:2, openMode:0} * fix reporter type-check * upgrade json-schemas, update snapshots * reformat error.stack to be only stacktrace, update snapshots * fix stacktrace replacing in 5_spec_isolation * fix navigation error causing infinite reloading, bump timeout on e2e/8_error_ui * fix server/unit tests for new schema * fix reporter/unit tests * fix reporting duplicate screenshots using cy.screenshot during test retry * update snapshot for 6_uncaught_support_file_spec * bump x-route-version: 3 * fix test.tsx collapsible content, css, fix e2e/8_error_ui, e2e projects excluding retries * fix css, fix padding in runnable-instruments, fix runner/integration tests * fixup after merge * fix reporter/runner to work with split hooks * update api tests, runner/cypress tests, reporter * fix 5_spec_isolation snapshots, fix runner/cypress errors.spec, fix null reference in test.tsx * fix e2e/non_root spec, fix type_check, fix reporter/unit tests * setup percy snapshots in runner/cypress, fix driver/runner test:after:run event, add tests for only,skip in runner/cypress, fix retried css * add customPercySnapshot * fix circle.yml * fix circle.yml 2 * fix circle.yml 3 * add warning for incompatible retries plugin * add more percy snapshots * fix firefox screenshot resolution in e2e test * Fix testConfigOverrides not affecting viewport (#8006) * finish adding percy snapshots to runner/cypress retries spec, update error msgs, add tests to be fixed * remove .only * fixing missing repo argument * fix testConfigOverrides usage with retries, fix test * fix issues from previous merge * add script that can query CircleCI workflow status * add circleci job to poll * add retries * try yarn lock * retry, percy finalize * check for current running job * do not swallow request error * better print * use job name from circle environment * use debug instead * renamed circle polling script * refactor circle to conditionally run percy-finalize when env var is available - pass job-names to wait on as an argument * use multi-line strings and quote --job-names - rename —circle-jobs to —job-names * add comment * only poll until the jobs to wait for are blocked or running * fix running hooks at correct depth after attempt fails from hook and will retry, update e2e snapshots * fix reporter/unit tests, remove unused toggleOpen code * move custom percy command into @packages/ui-components and apply them to desktop-gui * halt percy finalize job if env variable is not set * if only I could code * update runner/cypress mochaEvent snapshots, fix e2e firefox resolution * fix css for attempt border-left, fix attempt-tag open/close icon, add color to attempt collapsible dot * try percy set viewport width * set default retries back to {runMode:0, openMode:0} * formatting: add backticks to warning message * write explicit test for screenshot overwriting behavior, fix snapshots after changing retries defaults * fix e2e.it.only` * cleanup whitespace * update snapshots * fix cypress module API types for new result schema * build and upload binary for test-retries branch too (linux) * add pre-release PR comment * fix pre-release commit comment * rename runner/cypress test * update retries.ui.spec test titles * fix after merge: use most recent attempt for before/after hooks * add suite title to hook error in runner/cypress tests Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Brian Mann <brian.mann86@gmail.com> Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
#8148) * add retries output to server/reporter, fix mocha pass event order, cleanup * e2e tests - dont run electron tests in other browsers * Update readme to reflect how to start server for cypress tests * fix after merge * fix .coffee -> .js after merge * fix attempt.tsx * fix runnable titles emitted to terminal reporters * fix more tests: update snapshots, fix 7_record_spec, 8_reporters_spec * remove styling for 'attempt-error-region' so it's not indented - This was the older styling before error improvements and is no longer necessary. * try 2: fix rerun before/after hooks * fix runner with only, runner snapshots, lint fixes * temp 04/29/20 [skip ci] * backport changes from test-retries * change logic to rerun before hooks after top navigation * fix windowSize for browser e2e test * fix windowSize for xvfb chrome in e2e test * ok fine, just disable screenshots * fix after merge: decaffed navigation.js * update server/unit test snapshots * fix after merge: decaffed aliases.js * fix usage of cypress --parallel flag in circle.yml * fix circle.yml integration-tests jobs * fix decaf related typo * fix circle.yml separate command for runner-integration-tests * update runner/integration tests + snapshot after error improvements * fix runner/integration snapshots for chrome/ff stacktrace differences * rerun ci * fix passing --parallel to runner-integration tests * perf: faster lookup for hooks without runnables * fix afterAll hook switch logic * simplify mocha prototype patches * fix decaf utils.coffee after merge * backport to before/after fix * backport to before/after fix 2 * cleanup from decaf, fix ui/package.json * update helpers, simplify runner.spec * fix lint-types errors, flaky spec * fix noExit passed to e2e test inline options * cleanup snapshot utility - refactor to use util file * remove before/after changes * make cy obj a class instance * cleanup/unmerge before/after fixes PR... * more cleanup * add comment * fix runner.spec * cleanup snapshot utility more, cleanup reporter.spec * fix after merge * minor rename variable * fix after merge: decaffed files * fix specName in reporterHeader, spec_helper require * replace reporter specPath usages with spec object from config * cleanup, fix specs, fix types tests * fix config spec paths in isolated runner, fix snapshot plugin button * combine runner.spec.js and runner_spec.js * fix incorrect merge * minor minor cleanup * rename driver/test/cypress to driver/test * use yarn workspace over lerna for individual package commands * add error message to driver start * remove usage of wait-on * update <reference types/>, import string * fix driver/readme * fix readmes after regex replace * revert wait-on changes * Revert "revert wait-on changes" This reverts commit 6de684c. * update yarn.lock * fix broken path in spec * fix broken paths in specs with @packages/driver * move runner/test/cypress into runner/cypress * start server in pluginsFile in runner/cypress tests * fix more broken spec paths * fix broken paths after runner/cypress folder move * move type definition loading for driver/cypress into dedicated file * move internal-types to "types" folder, fix driver/index.d.ts * fix type-check in packages/runner. not exactly sure why * fix runner type-check by excluding test folder in tsconfig * bump timeout on e2e/8_error_ui_spec * update snapshot utility, rename tests in runner/runner.spec, fix README yarn commands * delete old spec * fix snapshot naming, remove redundant test in reporter_spec * fix file renames after merge * rename runner/ snapshot * update server/unit/reporter_spec snapshot * update runner/runner_spec snapshot * rename runner snapshot file * address feedback: move server reporter snapshot specs out * address feedback: add comment about exposing globals * fix test-retries after merging isolated-runner * fix runner/test helper, update snapshot * address feedback: split out runner/retries spec, move reporter/ui tests to runner/ui spec (mostly done), various cleanup * fix scrolling, attempt opening, update snapshots * fix e2e support file * fix 5_spec_isolation * fix mislabeling attempt screenshots * only add test results prevAttempts if exists * fix reporter/unit tests, server/unit tests * remove dead code, fix test isOpen * update snapshots for retries.mochaEvents, fix snapshot error in state hydration test, remove dead snapshots * new moduleAPI schema using attempts array, fix wrapping errors from hook retries, update snapshots * add displayError, null out fields in moduleAPI schema * change default retries to {runMode:2, openMode:0} * fix reporter type-check * upgrade json-schemas, update snapshots * reformat error.stack to be only stacktrace, update snapshots * fix stacktrace replacing in 5_spec_isolation * fix navigation error causing infinite reloading, bump timeout on e2e/8_error_ui * fix server/unit tests for new schema * fix reporter/unit tests * fix reporting duplicate screenshots using cy.screenshot during test retry * update snapshot for 6_uncaught_support_file_spec * bump x-route-version: 3 * fix test.tsx collapsible content, css, fix e2e/8_error_ui, e2e projects excluding retries * fix css, fix padding in runnable-instruments, fix runner/integration tests * fixup after merge * fix reporter/runner to work with split hooks * update api tests, runner/cypress tests, reporter * fix 5_spec_isolation snapshots, fix runner/cypress errors.spec, fix null reference in test.tsx * fix e2e/non_root spec, fix type_check, fix reporter/unit tests * setup percy snapshots in runner/cypress, fix driver/runner test:after:run event, add tests for only,skip in runner/cypress, fix retried css * add customPercySnapshot * fix circle.yml * fix circle.yml 2 * fix circle.yml 3 * add warning for incompatible retries plugin * add more percy snapshots * fix firefox screenshot resolution in e2e test * Fix testConfigOverrides not affecting viewport (#8006) * finish adding percy snapshots to runner/cypress retries spec, update error msgs, add tests to be fixed * remove .only * fixing missing repo argument * fix testConfigOverrides usage with retries, fix test * fix issues from previous merge * add script that can query CircleCI workflow status * add circleci job to poll * add retries * try yarn lock * retry, percy finalize * check for current running job * do not swallow request error * better print * use job name from circle environment * use debug instead * renamed circle polling script * refactor circle to conditionally run percy-finalize when env var is available - pass job-names to wait on as an argument * use multi-line strings and quote --job-names - rename —circle-jobs to —job-names * add comment * only poll until the jobs to wait for are blocked or running * fix running hooks at correct depth after attempt fails from hook and will retry, update e2e snapshots * fix reporter/unit tests, remove unused toggleOpen code * move custom percy command into @packages/ui-components and apply them to desktop-gui * halt percy finalize job if env variable is not set * if only I could code * update runner/cypress mochaEvent snapshots, fix e2e firefox resolution * fix css for attempt border-left, fix attempt-tag open/close icon, add color to attempt collapsible dot * try percy set viewport width * set default retries back to {runMode:0, openMode:0} * formatting: add backticks to warning message * write explicit test for screenshot overwriting behavior, fix snapshots after changing retries defaults * fix e2e.it.only` * cleanup whitespace * update snapshots * remap module API result, move e2e timing tests from 5_spec_isolation into 7_record_spec, unit test * fix cypress module API types for new result schema * build and upload binary for test-retries branch too (linux) * update module api typedefs for moving screenshot info * cleanup typedef * small refactor, add cypress-inspect-brk feat to e2e tests, fix typedefs for moduleapi * add pre-release PR comment * fix pre-release commit comment * rename runner/cypress test * update retries.ui.spec test titles * fix after merge: use most recent attempt for before/after hooks * add suite title to hook error in runner/cypress tests * fix snapshot Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Brian Mann <brian.mann86@gmail.com> Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
|
For the record...
|
* ignore sendFile EPIPE errors * upgrade @cypress/webpack-preprocessor to 5.4.4
* fix: validation logic issues
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo during release:
cypress-example-kitchensinkmust be deployed with this release 5.0.0 Release cypress-example-kitchensink#430cypress-test-node-versionsmust be merged with this release 5.0.0 Release - remove Node 8, add Node 10.0.0 cypress-test-node-versions#51cypress-example-recipesshould be updated and merged during this releaseDetails
whitelistRename uses of term 'whitelist' #7782blacklistRename configuration option blacklistHosts #7622Module API#8076