Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install specific Node version on Mac before building binary #8242

Merged
merged 28 commits into from
Aug 11, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Aug 10, 2020

To match the needed version from .node-version file

  • probably need to set up the same Node version in multiple jobs for Mac, like build and build-binary
    blocked by the code signing error on MAc
Frameworks/Electron Framework.framework/Versions/A/Electron Framework: code object is not signed at all

Screen Shot 2020-08-11 at 11 31 08 AM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 10, 2020

Thanks for taking the time to open a PR!

@bahmutov bahmutov changed the title Install specific Node version on Mac before building binary chore: install specific Node version on Mac before building binary Aug 10, 2020
@bahmutov bahmutov requested a review from flotwig August 10, 2020 20:13
@cypress
Copy link

cypress bot commented Aug 10, 2020



Test summary

8026 0 108 3


Run details

Project cypress
Status Passed
Commit ff07a32
Started Aug 11, 2020 5:18 PM
Ended Aug 11, 2020 5:25 PM
Duration 06:23 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig
Copy link
Contributor

flotwig commented Aug 10, 2020

@bahmutov this runs only on build job, right? I think we expect all tests to use the same Node version that was bundled with Electron, so that tests are using the same stdlib as they will be in Electron. So this should run on all test jobs (or at least all of the internal test jobs like server-unit-test, server-e2e-test...)

@bahmutov
Copy link
Contributor Author

yeah, it will require more stuff to happen here, every command needs to do this nonsense

@flotwig flotwig mentioned this pull request Aug 11, 2020
21 tasks
circle.yml Outdated
Comment on lines 941 to 942
nvm install v12.14.1
nvm alias default v12.14.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this hard coding the version instead of pulling it from .node-version?

@bahmutov
Copy link
Contributor Author

bahmutov commented Aug 11, 2020 via email

@bahmutov bahmutov merged commit dc523eb into v5.0-release Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants