-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: install specific Node version on Mac before building binary #8242
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@bahmutov this runs only on |
yeah, it will require more stuff to happen here, every command needs to do this nonsense |
circle.yml
Outdated
nvm install v12.14.1 | ||
nvm alias default v12.14.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this hard coding the version instead of pulling it from .node-version
?
Yup it is hard coding it for now
…Sent from my iPhone
On Aug 11, 2020, at 09:01, Brian Mann ***@***.***> wrote:
@brian-mann commented on this pull request.
In circle.yml:
> + nvm install v12.14.1
+ nvm alias default v12.14.1
isn't this hard coding the version instead of pulling it from .node-version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
To match the needed version from
.node-version
fileblocked by the code signing error on MAc