Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test v5 binary against Cypress Real World App #8240

Merged
merged 11 commits into from
Aug 11, 2020
Merged

chore: test v5 binary against Cypress Real World App #8240

merged 11 commits into from
Aug 11, 2020

Conversation

kevinold
Copy link
Contributor

No description provided.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 10, 2020

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kevinold kevinold requested a review from bahmutov August 10, 2020 19:30
@kevinold kevinold changed the title Test v5 binary against Cypress Real World App fix: test v5 binary against Cypress Real World App Aug 10, 2020
@cypress
Copy link

cypress bot commented Aug 10, 2020 •
edited
Loading


Test summary

8026 • 0 • 108 • 3

Run details
Project cypress
Status Passed
Commit d95220f
Started Aug 11, 2020 2:54 AM
Ended Aug 11, 2020 3:00 AM
Duration 06:02 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

bahmutov
bahmutov approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, and it is passing

bahmutov
bahmutov reviewed Aug 11, 2020
View reviewed changes
circle.yml Outdated Show resolved Hide resolved
bahmutov
bahmutov reviewed Aug 11, 2020
View reviewed changes
circle.yml Outdated Show resolved Hide resolved
bahmutov
bahmutov suggested changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take a look at my suggestion - I think it would be simpler

@kevinold
Copy link
Contributor Author

@bahmutov Thanks, updated.

bahmutov
bahmutov approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bahmutov bahmutov changed the title fix: test v5 binary against Cypress Real World App chore: test v5 binary against Cypress Real World App Aug 11, 2020
@bahmutov bahmutov merged commit 21748fa into v5.0-release Aug 11, 2020
@flotwig flotwig mentioned this pull request Aug 11, 2020
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinold @CLAassistant @bahmutov