Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use process.geteuid and catch uid errors in file util #17488

Merged
merged 7 commits into from
Jul 30, 2021
Merged

fix: use process.geteuid and catch uid errors in file util #17488

merged 7 commits into from
Jul 30, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jul 26, 2021

User facing changelog

  • Fixed an error "SystemError [ERR_SYSTEM_ERROR]: A system error occurred: uv_os_get_passwd returned ENOENT (no such file or directory)" that could occur when there is no /etc/passwd entry for the current user, such as in some Docker and GitHub Action setups.

Additional details

  • os.userInfo throws if there is no username, but we just need a uid, so process.geteuid works
  • process.geteuid throws on Windows, so catch that and return a constant (same way os.userInfo works on Windows)
  • added eslint rules to force developers to acknowledge process.geteuid/os.userInfo caveats

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 26, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 27, 2021 •
edited
Loading


Test summary

18192 • 0 • 214 • 7 • Flakiness 3

Run details
Project cypress
Status Passed
Commit 3d0c1b2
Started Jul 30, 2021 3:32 PM
Ended Jul 30, 2021 3:43 PM
Duration 10:44 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/commands/net_stubbing_spec.ts 3 Flakiness
1 network stubbing > intercepting request > should delay the same amount on every response
2 network stubbing > waiting and aliasing > can timeout incrementally waiting on requests
3 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review July 28, 2021 15:29
@flotwig flotwig requested a review from a team as a code owner July 28, 2021 15:29
@flotwig flotwig requested review from jennifer-shehane and kuceb and removed request for a team July 28, 2021 15:29
@flotwig flotwig merged commit 209efa4 into develop Jul 30, 2021
@cypress-bot cypress-bot bot mentioned this pull request Jul 30, 2021
Closed
@aboyce aboyce mentioned this pull request Jul 31, 2021
Closed
tgriesser added a commit that referenced this pull request Aug 2, 2021
@tgriesser
Merge branch 'unified-desktop-gui' into lmiller1990/unified-desktop-g…
db8ec2e 
…ui/add-context-code-review

* unified-desktop-gui:
  feat: Structuring context & schema so it can be used on the client (#17489)
  fix: vue 3 types, beta suffix & component name (#17508)
  fix: last test skipped with top navigation and already run suite (#17498)
  chore: Update Chrome (beta) to 93.0.4577.18 (#17536)
  fix: use process.geteuid and catch uid errors in file util (#17488)
  build: make vite build strict (#17509)
  release 8.1.0
  fix(server): correctly include projectRoot when adding a CI project from GUI (#17514)
  fix(types): update cy.shadow docs url (#17506)
  chore(npm/webpack-preprocessor): fix CI pipeline (#17515)
  fix: test runner reporter performance (#17243)
  chore: release @cypress/vue-v3.0.0-beta.4
  chore: release @cypress/vite-dev-server-v2.0.3
  fix: make vite re-run on supportFile change (#17485)
@flotwig flotwig deleted the issue-17415 branch January 24, 2022 18:20
This was referenced Apr 28, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuceb kuceb kuceb approved these changes

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cypress 8.0.0: A system error occurred: uv_os_get_passwd returned ENOENT (no such file or directory) on Docker
3 participants
@flotwig @kuceb @jennifer-shehane