Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: last test skipped with top navigation and already run suite #17498

Merged
merged 5 commits into from
Jul 30, 2021

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Jul 27, 2021

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@kuceb kuceb requested a review from a team as a code owner July 27, 2021 23:02
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 27, 2021

Thanks for taking the time to open a PR!

@kuceb kuceb requested review from chrisbreiding and jennifer-shehane and removed request for a team July 27, 2021 23:02
@kuceb kuceb changed the title fix: last runnable skipped with top navigation fix: last test skipped with top navigation and already run suite Jul 27, 2021
@cypress
Copy link

cypress bot commented Jul 27, 2021



Test summary

18192 0 214 7Flakiness 2


Run details

Project cypress
Status Passed
Commit a60684d
Started Jul 30, 2021 1:19 PM
Ended Jul 30, 2021 1:30 PM
Duration 10:58 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

querying_spec.js Flakiness
1 ... > logs elements length
net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified this fixes the original issue. 🎉

@jennifer-shehane jennifer-shehane merged commit 67c8a33 into develop Jul 30, 2021
tgriesser added a commit that referenced this pull request Aug 2, 2021
…ui/add-context-code-review

* unified-desktop-gui:
  feat: Structuring context & schema so it can be used on the client (#17489)
  fix: vue 3 types, beta suffix & component name (#17508)
  fix: last test skipped with top navigation and already run suite (#17498)
  chore: Update Chrome (beta) to 93.0.4577.18 (#17536)
  fix: use process.geteuid and catch uid errors in file util (#17488)
  build: make vite build strict (#17509)
  release 8.1.0
  fix(server): correctly include projectRoot when adding a CI project from GUI (#17514)
  fix(types): update cy.shadow docs url (#17506)
  chore(npm/webpack-preprocessor): fix CI pipeline (#17515)
  fix: test runner reporter performance (#17243)
  chore: release @cypress/vue-v3.0.0-beta.4
  chore: release @cypress/vite-dev-server-v2.0.3
  fix: make vite re-run on supportFile change (#17485)
@chrisbreiding chrisbreiding deleted the fix-9026-runnables branch April 5, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.8.0 Regression: Nested describes with before hook does not run final test
3 participants