refactor: use aliases instead of meta #19566
Conversation
+ use fs/promise instead of promisify
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
elevatebart
force-pushed
the
elevatebart/refactor/vite-plugin
branch
from
8f0fe6c
to
2126fc8
Compare
There was a problem hiding this comment.
Left one comment. Also it should be easy to add a system-test for this behavior (perhaps one for supportFile: '/somewhere' and supportFile: false? You could look at system-tests/tests/run-ct_spec.js. I don't think we have any system-tests using Vite so this would be quite nice to have. What do you think?
|
Adding a system test is a very good idea, I will add it before I merge this request. [EDIT] ... system tests are not implemented in 9.X will have to postpone. |
|
@elevatebart system tests are available for CT, look here: https://github.com/cypress-io/cypress/blob/master/system-tests/test/run_ct_spec.js |
|
I cannot understand how I missed that. Probably a case of the Mondays. Will make sure it's tested tomorrow and ping you then. |
|
@lmiller1990 system test added system-tests/test/vite_example_spec.ts |
* develop: feat: gray out the path to system node in cypress run header (#20121) feat: redesign server errors (#20072) test: fix awesome-typescript-loader test and remove test-binary job (#20131) fix: Fix issues with stack traces and command log in Chrome 99 (#20049) fix: `cy.type(' ')` fires click event on button-like elements. (#20067) fix: `change`, `input` events are not fired when the same option is selected again. (#19623) build: publish vue3 on latest (#20099) chore: release @cypress/webpack-preprocessor-v5.11.1 chore: release @cypress/webpack-dev-server-v1.8.1 fix: detect newly added specs in dev-server compilation (#17950) chore: Remove pkg/driver //@ts-nocheck part 3 (#19837) chore: set up semantic-pull-request GitHub Action (#20091) chore: release @cypress/react-v5.12.2 fix: remove nullish coalescing in js files to support node 12 (#20094) docs: update @cypress/webpack-preprocessor links (#19902) refactor: use aliases instead of meta (#19566)
User facing changelog
Probably more stable testing with vite.
Additional details
With the ambition to pregenerate vitejs tests this refactoring was necessary.
It brings the build philosophy closer to other rollup/vite plugins and makes it buildable.
Changes:
import.meta.env.__cypress_supportPathand__cypress_originAutUrluse strongly typed import aliasescypress:configcypress:spec-loaders. If the current spec is not pre-loaded, use a purely dynamic, but that should be the exceptioncypress:support-pathalias to access itstartServer.ts/start()code toindex.tsto simplify architectureresolveServerConfig.tssince it now only contains the config resolution