Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redesign server errors #20072

Merged
merged 172 commits into from
Feb 11, 2022
Merged

feat: redesign server errors #20072

merged 172 commits into from
Feb 11, 2022

Conversation

brian-mann
Copy link
Member

@brian-mann brian-mann commented Feb 7, 2022

User facing changelog

  • Improved error formatting, readability, and consistency for all errors displaying in stdout and in the desktop-gui
  • Duplicative stack traces are no longer rendered in the desktop-gui when the error originated from user code
  • User error stack traces originating from plugins are now constructed properly, with Cypress error handling lines removed
  • User errors are now "opened" by default in the desktop-gui

How has the user experience changed?

See the original issue: #20124 (comment) for examples of problematic errors

Consistent Styles & Formatting

image

image

Screen Shot 2022-02-09 at 2 13 58 PM

image

image

Screen Shot 2022-02-09 at 2 56 27 PM

image

Useful Stack Traces & Experience Improvements

image

image

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?

tgriesser and others added 30 commits January 27, 2022 19:55
- if base images don't exist, create them
- if base images don't match and local, overwrite them, if in CI throw
- if base images are stale and local, delete them, if in CI throw
@brian-mann brian-mann merged commit 29841f3 into develop Feb 11, 2022
@brian-mann brian-mann deleted the feat/redesign-errors branch February 11, 2022 07:06
tgriesser added a commit that referenced this pull request Feb 14, 2022
* develop:
  feat: gray out the path to system node in cypress run header (#20121)
  feat: redesign server errors (#20072)
  test: fix awesome-typescript-loader test and remove test-binary job (#20131)
  fix: Fix issues with stack traces and command log in Chrome 99 (#20049)
  fix: `cy.type(' ')` fires click event on button-like elements. (#20067)
  fix: `change`, `input` events are not fired when the same option is selected again. (#19623)
  build: publish vue3 on latest (#20099)
  chore: release @cypress/webpack-preprocessor-v5.11.1
  chore: release @cypress/webpack-dev-server-v1.8.1
  fix: detect newly added specs in dev-server compilation (#17950)
  chore: Remove pkg/driver //@ts-nocheck part 3 (#19837)
  chore: set up semantic-pull-request GitHub Action (#20091)
  chore: release @cypress/react-v5.12.2
  fix: remove nullish coalescing in js files to support node 12 (#20094)
  docs: update @cypress/webpack-preprocessor links (#19902)
  refactor: use aliases instead of meta (#19566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error experience in run mode and open mode
5 participants