Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redesign server errors #20072

Merged
merged 172 commits into from
Feb 11, 2022
Merged

feat: redesign server errors #20072

merged 172 commits into from
Feb 11, 2022

Commits on Jan 28, 2022

  1. chore: rename errors.js -> errors.ts

    @tgriesser
    tgriesser committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    912369f View commit details
    Browse the repository at this point in the history

  2. refactor: type safety on errors

    @tgriesser
    tgriesser committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    3114807 View commit details
    Browse the repository at this point in the history

  3. refactor: add err_template for consistent error formatting

    @tgriesser
    tgriesser committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    d9f4baf View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. fix a few system tests

    @tgriesser
    tgriesser committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    e0880a0 View commit details
    Browse the repository at this point in the history

  2. fix tests; update snapshots

    @brian-mann
    brian-mann committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    dc99313 View commit details
    Browse the repository at this point in the history

  3. Fix types

    @tgriesser
    tgriesser committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    c80f226 View commit details
    Browse the repository at this point in the history

  4. normalize snapshot - remove chalk ansi colors

    @brian-mann
    brian-mann committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    45e2221 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'tgriesser/chore/refactor-errors' of https://github.com/… 

    …cypress-io/cypress into tgriesser/chore/refactor-errors
    @brian-mann
    brian-mann committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    af2e9aa View commit details
    Browse the repository at this point in the history

  6. more unit test fixes

    @brian-mann
    brian-mann committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    3ebe6f7 View commit details
    Browse the repository at this point in the history

  7. more system test fixes

    @brian-mann
    brian-mann committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    74619e3 View commit details
    Browse the repository at this point in the history

  8. circleci build

    @brian-mann
    brian-mann committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    2faecf5 View commit details
    Browse the repository at this point in the history

  9. backtick always in stdout, fix error formatting and failing snapshots

    @brian-mann
    brian-mann committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    8322e07 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Merge branch 'develop' into tgriesser/chore/refactor-errors

    @tgriesser
    tgriesser authored Feb 1, 2022
    Configuration menu
    Copy the full SHA
    69d7fd6 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. refactor: create @packages/errors

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    32f3e18 View commit details
    Browse the repository at this point in the history

  2. fix import

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    931482d View commit details
    Browse the repository at this point in the history

  3. fix import

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3c7483e View commit details
    Browse the repository at this point in the history

  4. fixing build / tests

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    55499d1 View commit details
    Browse the repository at this point in the history

  5. remove extraneous file

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    b63865c View commit details
    Browse the repository at this point in the history

  6. move warnIfExplicitCiBuildId

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    8d2c963 View commit details
    Browse the repository at this point in the history

  7. fix build / tests

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5041e05 View commit details
    Browse the repository at this point in the history

  8. Fix

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    06b73b8 View commit details
    Browse the repository at this point in the history

  9. error, type fixes, documentation, standardize child process error ser… 

    …ialization
    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3fd2043 View commit details
    Browse the repository at this point in the history

  10. fix import

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    00e479a View commit details
    Browse the repository at this point in the history

  11. build errors on install

    @tgriesser
    tgriesser committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1dc7621 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. wrote specs generating visual images of all errors

    @brian-mann
    brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    6714aad View commit details
    Browse the repository at this point in the history

  2. remove unused dep

    @brian-mann
    brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    d2b2f8d View commit details
    Browse the repository at this point in the history

  3. sanitize stack traces

    @brian-mann
    brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7badd37 View commit details
    Browse the repository at this point in the history

  4. add image diffing 

    - if base images don't exist, create them
- if base images don't match and local, overwrite them, if in CI throw
- if base images are stale and local, delete them, if in CI throw
    @brian-mann
    brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    9ff1ca4 View commit details
    Browse the repository at this point in the history

  5. remove Courier New + MesloLGS NF font

    @brian-mann
    brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    1482206 View commit details
    Browse the repository at this point in the history

  6. type fixes, remove Bluebird, general cleanup

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    a75689b View commit details
    Browse the repository at this point in the history

  7. TS Cleanup

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    09d5c86 View commit details
    Browse the repository at this point in the history

  8. skip typecheck on tests for now

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7f7a1ae View commit details
    Browse the repository at this point in the history

  9. yarn.lock

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    ed39d17 View commit details
    Browse the repository at this point in the history

  10. fix @types/chai version

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    a097955 View commit details
    Browse the repository at this point in the history

  11. fix yarn.lock

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    73e88bc View commit details
    Browse the repository at this point in the history

  12. Different version of mocha types so it isnt patched

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7aa1f87 View commit details
    Browse the repository at this point in the history

  13. errors spec snapshot

    @brian-mann
    brian-mann committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    f35a3e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. CI fix

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    bc1823a View commit details
    Browse the repository at this point in the history

  2. fixes

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    5fb95a2 View commit details
    Browse the repository at this point in the history

  3. store snapshot images in circle artifacts

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    2a849ff View commit details
    Browse the repository at this point in the history

  4. dont change artifact destination prefix

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    98e47bb View commit details
    Browse the repository at this point in the history

  5. use Courier Prime

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    f713ef5 View commit details
    Browse the repository at this point in the history

  6. antialias the text

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    557ab5c View commit details
    Browse the repository at this point in the history

  7. decrease pixelmatch threshold, fail in CI only when changed pixels > 100

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    baf6430 View commit details
    Browse the repository at this point in the history

  8. increase timeout

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    f11bc28 View commit details
    Browse the repository at this point in the history

  9. overflow: hidden, remove new Promise, add debug logging 

    Co-Authored-By: Tim Griesser <tgriesser@gmail.com>
    @brian-mann @tgriesser
    brian-mann and tgriesser committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    8d77745 View commit details
    Browse the repository at this point in the history

  10. run unit tests w/ concurrency=1

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    d3efd64 View commit details
    Browse the repository at this point in the history

  11. unique window per file

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    672bf82 View commit details
    Browse the repository at this point in the history

  12. disable app hardware acceleration + use in process gpu + single process

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    61f1699 View commit details
    Browse the repository at this point in the history

  13. do not do image diffing 

    - conditionally convert html to images
- store html snapshots
- do not store images in git
    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    86a6192 View commit details
    Browse the repository at this point in the history

  14. store snapshot html

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    011e2aa View commit details
    Browse the repository at this point in the history

  15. Merge branch 'tgriesser/chore/refactor-errors' of https://github.com/… 

    …cypress-io/cypress into tgriesser/chore/refactor-errors
    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    c6232c6 View commit details
    Browse the repository at this point in the history

  16. remove concurrency

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    831f2d9 View commit details
    Browse the repository at this point in the history

  17. fix assertion

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    17f1ce6 View commit details
    Browse the repository at this point in the history

  18. fixing ci

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    d8c8446 View commit details
    Browse the repository at this point in the history

  19. Link in readme

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b95c2a3 View commit details
    Browse the repository at this point in the history

  20. pass the browsers to listItems

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    8935f18 View commit details
    Browse the repository at this point in the history

  21. fix: build @packages/errors in CI, defer import to prevent errors loc… 

    …ally
    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    7e9468d View commit details
    Browse the repository at this point in the history

  22. Merge branch 'develop' into tgriesser/chore/refactor-errors 

    * develop:
  chore: fix cypress npm package artifact upload path (#20023)
  chore(driver): move cy.within logic into it's own file (#20036)
  chore: update automerge workflows (#19982)
  fix(selectFile): use target window's File/DataTransfer classes (#20003)
  chore: Update Chrome (stable) to 98.0.4758.80 and Chrome (beta) to 98.0.4758.80 (#19995)
  fix: Adjust ffmpeg CLI args for performance (#19983)
  build: allow unified to run cypress on Apple Silicon (arm64) (backport #19067 to 9.x) (#19968)
    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    9995f25 View commit details
    Browse the repository at this point in the history

  23. fix run-if-ci.sh

    @tgriesser @brian-mann
    tgriesser authored and brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    fddc4f0 View commit details
    Browse the repository at this point in the history

  24. Merge branch 'develop' into tgriesser/chore/refactor-errors

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    149001a View commit details
    Browse the repository at this point in the history

  25. remove dead code

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b444007 View commit details
    Browse the repository at this point in the history

  26. Mark the .html files as generated in gitattributes

    @tgriesser
    tgriesser committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    6df0f20 View commit details
    Browse the repository at this point in the history

  27. fix running single error case, slice out more of the brittle stack

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    5f4bdf5 View commit details
    Browse the repository at this point in the history

  28. remove additional brittle stack line

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    0d4f1ec View commit details
    Browse the repository at this point in the history

  29. firefox web security error

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    f99fb05 View commit details
    Browse the repository at this point in the history

  30. nest inside of describe

    @brian-mann
    brian-mann committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    e53647c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2022

  1. reformat and redesign errors

    @brian-mann
    brian-mann committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    e62d1a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. more error cleanup and standardization

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a1deba7 View commit details
    Browse the repository at this point in the history

  2. additional formatting of errors, code cleanup, refactoring

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    941ac21 View commit details
    Browse the repository at this point in the history

  3. update ansi colors to match terminal colors

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    f6a00c0 View commit details
    Browse the repository at this point in the history

  4. cleanup remaining loose ends, update several errors, compact excess f… 

    …ormatters
    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    9da5e6f View commit details
    Browse the repository at this point in the history

  5. fix types

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    58173e2 View commit details
    Browse the repository at this point in the history

  6. additional formatting, remove TODO's, ensure no [object Object] in ou… 

    …tput
    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    f6caadf View commit details
    Browse the repository at this point in the history

  7. add test for 412 server response on invalid schema

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    490b524 View commit details
    Browse the repository at this point in the history

  8. update unknown dashboard error on creating run

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    53d7360 View commit details
    Browse the repository at this point in the history

  9. use fs.access instead of fs.stat for perf

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    80be4b5 View commit details
    Browse the repository at this point in the history

  10. added PLUGINS_FILE_NOT_FOUND error 

    - separated out from PLUGINS_FILE_ERROR
- add system tests for both cases
- update snapshots
- remove stack trace from PLUGINS_FILE_NOT_FOUND fka PLUGINS_FILE_ERROR
    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    9ba362c View commit details
    Browse the repository at this point in the history

  11. add plugins system test around plugins synchronously throwing on require

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    e9c926a View commit details
    Browse the repository at this point in the history

  12. remove forcing process.cwd() to be packages/server, update affected code 

    - this was a long needed hangover from very old code that was doing unnecessary things due to respawning electron from node and handling various entrypoints into booting cypress
- this also makes the root yarn dev and dev-debug work correctly because options.cwd is set correctly now
    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    63231c7 View commit details
    Browse the repository at this point in the history

  13. perf: lazy load chalk

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    978ce03 View commit details
    Browse the repository at this point in the history

  14. remove excessive line since the file exists but is invalid

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    e454600 View commit details
    Browse the repository at this point in the history

  15. fix types

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    4cbbab2 View commit details
    Browse the repository at this point in the history

  16. add system test when plugins function throws a synchronous error

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    983f969 View commit details
    Browse the repository at this point in the history

  17. create new PLUGINS_INVALID_EVENT_ERROR, wire it up correctly for erro… 

    …r template use

- properly pass error instance from child to ensure proper user stack frames
- move error display code into the right place
    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a3dc456 View commit details
    Browse the repository at this point in the history

  18. only show a single stack trace, either originalError or internal cypr… 

    …essError
    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    b67edb9 View commit details
    Browse the repository at this point in the history

  19. push error html snapshots

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a5ef964 View commit details
    Browse the repository at this point in the history

  20. fix tests, types

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    bab19ee View commit details
    Browse the repository at this point in the history

  21. fix test

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    75929ae View commit details
    Browse the repository at this point in the history

  22. fix failing tests

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    d48d3f9 View commit details
    Browse the repository at this point in the history

  23. fix tests

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    f9b474f View commit details
    Browse the repository at this point in the history

  24. fixes lots of broken tests

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    f7e7c30 View commit details
    Browse the repository at this point in the history

  25. more test fixes

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a3ee5ac View commit details
    Browse the repository at this point in the history

  26. fixes more tests

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    d580755 View commit details
    Browse the repository at this point in the history

  27. fix type checking

    @brian-mann
    brian-mann committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    38c3e83 View commit details
    Browse the repository at this point in the history

  28. wip: consistent handling of interpolated values

    @tgriesser
    tgriesser committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    e600767 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. feat: fixing up errors, added simple error comparison tool

    @tgriesser
    tgriesser committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    fa82f2d View commit details
    Browse the repository at this point in the history

  2. wrapping up error formatting

    @tgriesser
    tgriesser committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    1a2dbef View commit details
    Browse the repository at this point in the history

  3. Fixes for unit tests

    @tgriesser
    tgriesser committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    e808c7e View commit details
    Browse the repository at this point in the history

  4. fix PLUGINS_VALIDATION_ERROR

    @tgriesser
    tgriesser committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    b08dfd8 View commit details
    Browse the repository at this point in the history

  5. fix fs.readdir bug, show rows even if there's only markdown formattin… 

    …g [SKIP CI]
    @brian-mann
    brian-mann committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    91641ea View commit details
    Browse the repository at this point in the history

  6. when in base-list, show full width of errors

    @brian-mann
    brian-mann committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    d82e8cb View commit details
    Browse the repository at this point in the history

  7. Fix type errors

    @tgriesser
    tgriesser committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    49d739e View commit details
    Browse the repository at this point in the history

  8. added searching and filtering for files based on error name

    @brian-mann
    brian-mann committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    bba9685 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feat/redesign-errors' of https://github.com/cypress-io/… 

    …cypress into feat/redesign-errors
    @brian-mann
    brian-mann committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    fae706d View commit details
    Browse the repository at this point in the history

  10. fix: system tests

    @tgriesser
    tgriesser committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    9f6a43c View commit details
    Browse the repository at this point in the history

  11. updated NO_SPECS_FOUND error to properly join searched folder + pattern 

    - join patterns off of process.cwd, not projectRoot
- highlight original specPattern in yellow, baseDir in blue
- add tests
    @brian-mann
    brian-mann committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    39036ad View commit details
    Browse the repository at this point in the history

  12. Merge branch 'feat/redesign-errors' of https://github.com/cypress-io/… 

    …cypress into feat/redesign-errors
    @brian-mann
    brian-mann committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    5ad25e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. fixes failing tests

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    0360bc9 View commit details
    Browse the repository at this point in the history

  2. fix test

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    ea6b2d5 View commit details
    Browse the repository at this point in the history

  3. preserve original spec pattern, display relative to projectRoot for t… 

    …erminal banner
    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    95f2213 View commit details
    Browse the repository at this point in the history

  4. make the nodeVersion path display in gray, not white

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    e068176 View commit details
    Browse the repository at this point in the history

  5. fix tests, pass right variables

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    45c1a73 View commit details
    Browse the repository at this point in the history

  6. fix chrome:canary snapshots

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    1062106 View commit details
    Browse the repository at this point in the history

  7. update snapshots

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    2470ec4 View commit details
    Browse the repository at this point in the history

  8. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    307c522 View commit details
    Browse the repository at this point in the history

  9. strip newlines caused by "Still waiting to connect to {browser}..."

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6f0edc1 View commit details
    Browse the repository at this point in the history

  10. don't remove the snapshotHtmlFolder in CI, add additional verificatio… 

    …n snapshots match to error keys symmetrically
    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    de68a21 View commit details
    Browse the repository at this point in the history

  11. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    2ef825f View commit details
    Browse the repository at this point in the history

  12. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    9659bdb View commit details
    Browse the repository at this point in the history

  13. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    a343e66 View commit details
    Browse the repository at this point in the history

  14. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    2e8e088 View commit details
    Browse the repository at this point in the history

  15. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6f89d9d View commit details
    Browse the repository at this point in the history

  16. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    b527e74 View commit details
    Browse the repository at this point in the history

  17. update gitignore

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    f65972e View commit details
    Browse the repository at this point in the history

  18. fix snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    a3aadba View commit details
    Browse the repository at this point in the history

  19. update snapshot html

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    1969854 View commit details
    Browse the repository at this point in the history

  20. update logic for parsing the resolve pattern matching, add tests

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6636722 View commit details
    Browse the repository at this point in the history

  21. update snapshots

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    19acbb4 View commit details
    Browse the repository at this point in the history

  22. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    60731a6 View commit details
    Browse the repository at this point in the history

  23. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    f1394d8 View commit details
    Browse the repository at this point in the history

  24. update snapshot

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    5089800 View commit details
    Browse the repository at this point in the history

  25. fix failing test

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    7179ccd View commit details
    Browse the repository at this point in the history

  26. fix: error_message_spec

    @tgriesser
    tgriesser committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    23181e7 View commit details
    Browse the repository at this point in the history

  27. fix snapshot

    @tgriesser
    tgriesser committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    fd35999 View commit details
    Browse the repository at this point in the history

  28. run each variant through an it(...) so multiple failures are received

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6a0e00b View commit details
    Browse the repository at this point in the history

  29. add newlines to multiline formatters, add fmt.stringify, allow format… 

    … overrides
    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    cd76bcf View commit details
    Browse the repository at this point in the history

  30. stringify invalid return values from plugins

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    b32e91f View commit details
    Browse the repository at this point in the history

  31. move config validation errors into packages/errors, properly highligh… 

    …t and stringify values
    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    af1baf6 View commit details
    Browse the repository at this point in the history

  32. add component testing yarn commands

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    16e19f3 View commit details
    Browse the repository at this point in the history

  33. fix the arrow not showing on details

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    0bb1ea9 View commit details
    Browse the repository at this point in the history

  34. fix typescript error

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6091353 View commit details
    Browse the repository at this point in the history

  35. fixed lots of poorly written tests that weren't actually testing anyt… 

    …hing. created settings validation error when given a string validation result.
    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    05a3917 View commit details
    Browse the repository at this point in the history

  36. fixes tests

    @brian-mann
    brian-mann committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    3ecde09 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. fixes tests, adds new error template for validating within an array l… 

    …ist (for browser validation)
    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    11f47b2 View commit details
    Browse the repository at this point in the history

  2. remove dupe line

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    114dd02 View commit details
    Browse the repository at this point in the history

  3. fix copy for consistency, update snapshots

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3268eab View commit details
    Browse the repository at this point in the history

  4. remove redundant errors, standardize formatting and phrasing

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    7d4292b View commit details
    Browse the repository at this point in the history

  5. more formatting

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    b748c1f View commit details
    Browse the repository at this point in the history

  6. remove excess snapshots

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    04a9389 View commit details
    Browse the repository at this point in the history

  7. prune out excessive error snapshot html files when not in CI

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    05f9103 View commit details
    Browse the repository at this point in the history

  8. add missing tests, add case for when config validation fails without … 

    …a fileType
    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3f47bd6 View commit details
    Browse the repository at this point in the history

  9. fixes test

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2307e44 View commit details
    Browse the repository at this point in the history

  10. update snapshot

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    23241f5 View commit details
    Browse the repository at this point in the history

  11. update snapshot

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    ed274fa View commit details
    Browse the repository at this point in the history

  12. update snapshot

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    95d6856 View commit details
    Browse the repository at this point in the history

  13. sort uniqErrors + errorKeys prior to assertion - assert one by one

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3fed188 View commit details
    Browse the repository at this point in the history

  14. add system test for binding to an event with the wrong handler

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    703d976 View commit details
    Browse the repository at this point in the history

  15. fixes tests

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    6e484a5 View commit details
    Browse the repository at this point in the history

  16. set more descriptive errors when setting invalid plugin events, or du… 

    …ring plugin event validation
    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    42316ae View commit details
    Browse the repository at this point in the history

  17. remove duplicate PLUGINS_EVENT_ERROR, collapse into existing error

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    84cb7e2 View commit details
    Browse the repository at this point in the history

  18. use the same multiline formatting as @packages/errors

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    01f3d5e View commit details
    Browse the repository at this point in the history

  19. standardize verbiage and highlighting for consistency

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    c10421e View commit details
    Browse the repository at this point in the history

  20. fix incorrect error path

    @brian-mann
    brian-mann committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    ef463e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. fixes tests, standardized and condensed more language

    @brian-mann
    brian-mann committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    293afe5 View commit details
    Browse the repository at this point in the history

  2. Update packages/errors/src/errors.ts 

    Co-authored-by: Ryan Manuel <ryanm@cypress.io>
    @brian-mann @ryanthemanuel
    brian-mann and ryanthemanuel authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    ac14cce View commit details
    Browse the repository at this point in the history

  3. Update guides/error-handling.md 

    Co-authored-by: Ryan Manuel <ryanm@cypress.io>
    @brian-mann @ryanthemanuel
    brian-mann and ryanthemanuel authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    45d2682 View commit details
    Browse the repository at this point in the history

  4. Update guides/error-handling.md 

    Co-authored-by: Ryan Manuel <ryanm@cypress.io>
    @brian-mann @ryanthemanuel
    brian-mann and ryanthemanuel authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    6507133 View commit details
    Browse the repository at this point in the history

  5. added some final todo's

    @brian-mann
    brian-mann committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    58a74a3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feat/redesign-errors' of https://github.com/cypress-io/… 

    …cypress into feat/redesign-errors
    @brian-mann
    brian-mann committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    4896c73 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into feat/redesign-errors

    @brian-mann
    brian-mann authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    6dec56b View commit details
    Browse the repository at this point in the history

  8. fix types

    @brian-mann
    brian-mann committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    879d30c View commit details
    Browse the repository at this point in the history