fix: error regression - unexpected ANSI color chars shown on Firefox warning message about chromeWebSecurity #20512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
davidmunechika
changed the title
davidmunechika
changed the title
davidmunechika
requested review from
jennifer-shehane
and removed request for
a team
jennifer-shehane
approved these changes
Mar 7, 2022
mjhenkes
approved these changes
Mar 7, 2022
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fix regression that caused ANSI color chars to show up on Firefox warning message about
chromeWebSecurityAdditional details
This regression was introduced in Cypress version 9.5.0 as a result of this PR: #20072 where errors originating from the server (
@packages/errors) were altered as part of a larger errors improvement.To fix this regression, I simply stripped the ANSI chars from the warning message, since this config will display differently in 10.0 and will be deprecated with multi-domain anyway.
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?